Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on Close (x) icon throws a JS error in the console #16

Open
synergies opened this issue Dec 12, 2018 · 1 comment
Open

Clicking on Close (x) icon throws a JS error in the console #16

synergies opened this issue Dec 12, 2018 · 1 comment

Comments

@synergies
Copy link

When you click on the Close (x) icon, it throws the following JS error:

video.js:498 VIDEOJS: ERROR: TypeError: Cannot read property 'trigger' of null
    at e.close (videojs-share.min.js:7)
    at CloseButton.bound (video.js:2348)
    at HTMLButtonElement.bound (video.js:2348)
    at HTMLButtonElement.data.dispatcher (video.js:1971)
    at trigger (video.js:2103)
    at CloseButton.trigger$$1 [as trigger] (video.js:2964)
    at CloseButton.handleClick (video.js:12956)
    at HTMLButtonElement.bound (video.js:2348)
    at HTMLButtonElement.data.dispatcher (video.js:1971)
@avdeev
Copy link
Collaborator

avdeev commented Dec 12, 2018

@synergies Yep, it is possible on this line.

player.trigger('sharing:closed');

You can try to fix it and make PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant