Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UltraVNC setup file cleanup not working #97

Closed
DoLearnWhileAlive opened this issue Mar 3, 2021 · 2 comments · Fixed by #98
Closed

UltraVNC setup file cleanup not working #97

DoLearnWhileAlive opened this issue Mar 3, 2021 · 2 comments · Fixed by #98

Comments

@DoLearnWhileAlive
Copy link
Contributor

Expected Behavior

UltraVNC setup files should be removed after installation or a ignore file should be created for all setup files to avoid shimming

Current Behavior

UltraVNC setup files are not removed after installation and a ignore file is only created for the installed setup file

[DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\ultravnc\ultravnc.nupkg'
  with checksum 'ED64399D418B7F519C7E0CC120FFBA6B'
[DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\ultravnc\ultravnc.nuspec'
  with checksum '132D60F8F390C3412E218C1DEAB98482'
[DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\ultravnc\legal\LICENSE.txt'
  with checksum 'B8A220CE1364B2962770AF627EFD140C'
[DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\ultravnc\legal\VERIFICATION.txt'
  with checksum '5C6DE420449F82A9F39DB8D38DB1E134'
[DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\ultravnc\tools\chocolateyInstall.ps1'
  with checksum 'E9E7F502A1E099D4CA83594683AD703B'
[DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\ultravnc\tools\UltraVNC_1_3_2_X64_Setup.exe'
  with checksum 'F252FF6C4CF33E28554FCB7258795910'
[DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\ultravnc\tools\UltraVNC_1_3_2_X64_Setup.exe.ignore'
  with checksum 'BEA07E6D2B8DCE396FE21BAA61B34956'
[DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\ultravnc\tools\UltraVNC_1_3_2_X86_Setup.exe'
  with checksum 'C87DF268505C33354EE1F4429493C3CB'
[DEBUG] - Calling command ['"C:\ProgramData\chocolatey\tools\shimgen.exe" --path="..\\lib\ultravnc\tools\UltraVNC_1_3_2_X86_Setup.exe" --output="C:\ProgramData\chocolatey\bin\UltraVNC_1_3_2_X86_Setup.exe"  --iconpath="C:\ProgramData\chocolatey\lib\ultravnc\tools\UltraVNC_1_3_2_X86_Setup.exe"']
[DEBUG] -  [ShimGen] Microsoft (R) Visual C# Compiler version 4.8.3761.0
[DEBUG] - Command ['"C:\ProgramData\chocolatey\tools\shimgen.exe" --path="..\\lib\ultravnc\tools\UltraVNC_1_3_2_X86_Setup.exe" --output="C:\ProgramData\chocolatey\bin\UltraVNC_1_3_2_X86_Setup.exe"  --iconpath="C:\ProgramData\chocolatey\lib\ultravnc\tools\UltraVNC_1_3_2_X86_Setup.exe"'] exited with '0'
[DEBUG] -  [ShimGen] for C# 5
[INFO ] -  ShimGen has successfully created a shim for UltraVNC_1_3_2_X86_Setup.exe
[DEBUG] -  [ShimGen] Copyright (C) Microsoft Corporation. All rights reserved.
[DEBUG] -   Created: C:\ProgramData\chocolatey\bin\UltraVNC_1_3_2_X86_Setup.exe
  Targeting: C:\ProgramData\chocolatey\lib\ultravnc\tools\UltraVNC_1_3_2_X86_Setup.exe
  IsGui:False

[DEBUG] -  [ShimGen] This compiler is provided as part of the Microsoft (R) .NET Framework, but only supports language versions up to C# 5, which is no longer the latest version. For compilers that support newer versions of the C# programming language, see http://go.microsoft.com/fwlink/?LinkID=533240
[DEBUG] -  [ShimGen] ShimGen has successfully created 'C:\ProgramData\chocolatey\bin\UltraVNC_1_3_2_X86_Setup.exe'

Possible Solution

chocolateyInstall.ps1 should correctly use variable $toolsDir instead of undefined variable $toolsPath

Steps to Reproduce (for bugs)

just install UltraVNC with chocolatey

Your Environment

  • Package Version used: 1.3200
  • Operating System and version: Server 2012 R2
  • Chocolatey version: latest
  • Install/uninstall gist:
@DoLearnWhileAlive
Copy link
Contributor Author

Found multiple packages affected here. Pull Request fixes all 11 affected packages.

@Neustradamus
Copy link

Dear all, @mkevenaar,

I have done a ticket to have a fix about bad UltraVNC version numbers in Chocolatey:

In more, I have done a ticket one year ago about 1.4.3.6:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants