Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Channel1Stem1] -> [Channel1_Stem1] #14240

Closed
daschuer opened this issue Jan 26, 2025 · 8 comments · Fixed by #14244
Closed

[Channel1Stem1] -> [Channel1_Stem1] #14240

daschuer opened this issue Jan 26, 2025 · 8 comments · Fixed by #14244
Labels
Milestone

Comments

@daschuer
Copy link
Member

Bug Description

When creating a tree like dictionary of COs for the OSC project, it turns out, that we have one exceptional group.
It is "[Channel1Stem1]" for all other controls an _ is following after any index. Like [EffectRack1_EffectUnit1_Effect1]

Since we are still in alpha, it is early enough to fix it. This will avoid to special case this when looking up COs. It will hopefully also avoid a pit of confusion when writing mappings.

Since the number of stem enabled mappings is reasonable small I propose to do to without an alias.
An alias will create 20824 entries wasting a high amount of RAM.

What do you think?

Version

No response

OS

No response

@daschuer daschuer added the bug label Jan 26, 2025
@daschuer daschuer added this to the 2.6-beta milestone Jan 26, 2025
@Holzhaus
Copy link
Member

I'd be for it, but let's do it ASAP before more mappings start using it.

@Eve00000
Copy link
Contributor

as we're still in alpha can we also adjust the inconsistencies with stems
in QuickEffectRackX : the double brackets and no underscore
eg [QuickEffectRackX_[ChannelYStemZ]] -> [QuickEffectRackX_ChannelY_StemZ]

and if possible also the brackets in the middle of a co-name?
eg [EqualizerRackX_[ChannelY]_EffectZ] ->[EqualizerRackX_ChannelY_EffectZ]

I'm also asking it for the tree/branch/leaf structure

@daschuer
Copy link
Member Author

Yes, however we are partially bound to legacy:
The legacy pattern is

[EqualizerRackX_[group]_EffectZ]
So we can only fix it like:

[QuickEffectRackX_[ChannelY_StemZ]_EffectZ]

@Eve00000
Copy link
Contributor

Yes, however we are partially bound to legacy: The legacy pattern is
[EqualizerRackX_[group]EffectZ] So we can only fix it like:
[QuickEffectRackX
[ChannelY_StemZ]_EffectZ]

Ok legacy, so we can't replace, but we can add a second one without the double brackets?

@Holzhaus
Copy link
Member

We could, but it would use more memory. Also, I think the brackets make sense now that we have stems.

Because for [QuickEffectRackX_[ChannelY_StemZ]_EffectZ] you can easily see which channel it applies to, in contrast to [QuickEffectRackX_ChannelY_StemZ_EffectZ].

@Eve00000
Copy link
Contributor

Eve00000 commented Jan 28, 2025

translating
/EqualizerRack1/Channel2/Effect1/parameter1
to
[EqualizerRack1_Channel2_Effect1],parameter1
would be easier han to
[EqualizerRack1_[Channel2]_Effect1],parameter1
(in making translation rules)

@Holzhaus
Copy link
Member

I need a little more context here. What translation rules?

@Eve00000
Copy link
Contributor

I need a little more context here. What translation rules?

See PR #14238 : Osc in mixxx -> /Tree/Banch/Leaf -> experimental
See PR #14229 : [POC] OSCQuery
'Translation' - rules to translate (transpose - convert ... ) url-formatted commands /tree/branch/leaf to CO's, using OSC as base but to step up in the future to eg IoT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants