Remove broken guard #6
Conversation
As far as I can tell that `if` statement is _always_ true, since `fileInstallingPath` is the path to the package running the ‘install’ or ‘postInstall’ script, which is the package being installed—which is what `$npm_package_name` refers to.
| } | ||
|
|
||
| if (fileInstallingPackagePath.match(".+" + process.env.npm_package_name + "$")) { |
There was a problem hiding this comment.
Yes, this is a bug; the change you made what was intended!
There was a problem hiding this comment.
@wearhere Actually, sorry about the previous comment. I meant I would have wanted to check target.match(...). My intentions here were to catch a case where the project that hosts the shared files runs npm install. In this case, the process was running against itself, which was not ideal (but in thinking about it now, in some scenarios, this could be necessary). I would say a better cross-version solution here would be to check to see if the source and the target package names are the same, and reject if that is the case. Thoughts?
There was a problem hiding this comment.
a better cross-version solution here would be to check to see if the source and the target package names are the same, and reject if that is the case
Yeah that sounds like it could work!
There was a problem hiding this comment.
Tracking this bug here #8
No description provided.