Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-files shouldn't run if its client is being installed directly #8

Open
wearhere opened this issue Feb 15, 2017 · 1 comment
Open

Comments

@wearhere
Copy link
Contributor

wearhere commented Feb 15, 2017

Install scripts, thus install-files, run both when the package using install-files is installed directly as well as when it's installed as a dependency of another package. We only want install-files to run in the latter scenario since it's supposed to copy the files to that dependent.

To use the example from the README, install-files should run if the user runs npm install my-ebextensions from my-microservice's directory. It should not run if the user cds into my-ebextensions and runs npm install there.

@wearhere
Copy link
Contributor Author

This is a minor bug since install-files packages don't run standalone so you basically never need to run npm install inside them, at least I don't. You could work around this by adding the install script last when developing such a package, or avoiding even doing npm install install-files but rather just copying the package.json from another install-files package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant