New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenID Connect Client - missing acct: prefix in webfinger request #1541

Open

serkansbo opened this issue Jul 28, 2020 · 0 comments

serkansbo commented Jul 28, 2020

When identifier is [email protected], WebfingerIssuerService.WebfingerIssuerFetcher fetches the url:

https://example.com/.well-known/webfinger?resource=XXXX%40example.com&rel=http%3A%2F%2Fopenid.net%2Fspecs%2Fconnect%2F1.0%2Fissuer

when it should be adding 'acct:' and fetching:

https://example.com/.well-known/webfinger?resource=acct%3AXXXX%40example.com&rel=http%3A%2F%2Fopenid.net%2Fspecs%2Fconnect%2F1.0%2Fissuer

I think this can be fixed by adding "acct:" prefix to "identifier" at https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/blob/master/openid-connect-client/src/main/java/org/mitre/openid/connect/client/service/impl/WebfingerIssuerService.java#L249.

Related to https://gitlab.com/openid/conformance-suite/-/issues/788.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment