Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes are not exported properly due to being marked 'default' #132

Open
Amndeep7 opened this issue Dec 20, 2023 · 1 comment
Open

Classes are not exported properly due to being marked 'default' #132

Amndeep7 opened this issue Dec 20, 2023 · 1 comment

Comments

@Amndeep7
Copy link

If you use intellisense, you can see that while these classes exist you can't actually access them. I think it's something to do with how 'default' works within js but honestly I find it kinda confusing. However, I think if we just remove the 'default' keyword for all the classes (similar to how we don't have it for all of the exported functions) then it should become possible to import them in external libraries. I believe it's working internally within this library due to importing them directly from their various files via relative paths.

@aaronlippold
Copy link
Member

I ran into this as well and some of my PR‘s. You can only have one default export in the class, so it’s safest just to usually export rather than make anything default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants