-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Tag Cleaning on Frontend #6052
base: master
Are you sure you want to change the base?
Conversation
charleshu-8
commented
Aug 1, 2024
•
edited
Loading
edited
- Make frontend display any tags given in the OHDF object.
Signed-off-by: Charles Hu <[email protected]>
The tags stem from how the Fortify mapper doesn't seem to clean up the XML tags that are converted and used in its mappings. Adding a tag filter on the HTML export side removes these tags to mirror how we do things on the frontend, but it does seem like some context is lost as a result of the tags encoding some information. EX)
As this behavior is mirrored on the frontend as well, I recommend addressing this issue in a rework of the Fortify mapper instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not agree with this PR.
I am actually fine with the raw HTML showing up in the results cause now we can see the full information.
I think the correct direction would be to fix both the frontend and the HTML export to allow for displaying HTML formatted data.
Signed-off-by: Charles Hu <[email protected]>
Pivoting this to instead remove tag cleaning on Heimdall frontend. |
Quality Gate passedIssues Measures |