Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught TypeError when setting reading time estimate #2113

Closed
moppman opened this issue Oct 6, 2023 · 0 comments · Fixed by #2119
Closed

Uncaught TypeError when setting reading time estimate #2113

moppman opened this issue Oct 6, 2023 · 0 comments · Fixed by #2119
Labels
bug

Comments

@moppman
Copy link

moppman commented Oct 6, 2023 •
edited
Loading

Hi,
how to reproduce:

  1. Have "Show estimated reading time for entries" in the global settings disabled.
  2. Open any feed entry and click "Download".
  3. Observe the following console error message:
Uncaught (in promise) TypeError: Cannot set properties of null (setting 'innerHTML')

which is thrown here , because data.reading_time is apparently null .entry-reading-time does not exist at this point.

If I enable "Show estimated reading time for entries", I can no longer observe the error.

This is on v2.0.48.

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Javascript error when reading time option is disabled miniflux/v2
2 participants
@fguillot @moppman