From 74376cd33cb67612a89192d00fc62c6d144b4aa5 Mon Sep 17 00:00:00 2001
From: Ztec <ztec@riper.fr>
Date: Tue, 3 Sep 2024 14:07:47 +0200
Subject: [PATCH] fix: remove progression save on shared entry

Shared entry does not link to any user and therefore should not display
any saved progression. Curiously, the progression of a user (the one that shared ?)
was still integrated in the page. This does not make sens regarding the sharing
feature itself. It is also a leak of user personal information onto a public page.

I simply removed the data from the template when the user object is not present.
I tested the change on "regular" entry page, ensuring the save progression feature
still works, and on shared page checking if any error happened in the JavaScript console.
Everything seems in order.
---
 internal/template/templates/views/entry.html | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/internal/template/templates/views/entry.html b/internal/template/templates/views/entry.html
index a9a4b07b363..7e082e5604e 100644
--- a/internal/template/templates/views/entry.html
+++ b/internal/template/templates/views/entry.html
@@ -171,12 +171,12 @@ <h1 id="page-header-title" dir="auto">
     {{ if hasPrefix .MimeType "audio/" }}
     <div class="enclosure-audio" >
         <audio controls preload="metadata"
-            data-last-position="{{ .MediaProgression }}"
+            {{ if $.user }}data-last-position="{{ .MediaProgression }}"{{ end }}
             {{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }}
             {{ if $.user.MarkReadOnMediaPlayerCompletion }}
                data-mark-read-on-completion="0.9"
             {{ end }}
-            data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"
+            {{ if $.user }}data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"{{ end }}
             data-enclosure-id="{{.ID}}"
             >
             {{ if (and $.user (mustBeProxyfied "audio")) }}
@@ -190,12 +190,12 @@ <h1 id="page-header-title" dir="auto">
         {{ else if hasPrefix .MimeType "video/" }}
         <div class="enclosure-video">
             <video controls preload="metadata"
-                data-last-position="{{ .MediaProgression }}"
+                {{ if $.user }}data-last-position="{{ .MediaProgression }}"{{ end }}
                 {{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }}
                 {{ if $.user.MarkReadOnMediaPlayerCompletion }}
                     data-mark-read-on-completion="0.9"
                 {{ end }}
-                data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"
+                {{ if $.user }}data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"{{ end }}
                 data-enclosure-id="{{.ID}}"
                 >
                 {{ if (and $.user (mustBeProxyfied "video")) }}
@@ -225,12 +225,12 @@ <h1 id="page-header-title" dir="auto">
         {{ if hasPrefix .MimeType "audio/" }}
         <div class="enclosure-audio">
             <audio controls preload="metadata"
-                data-last-position="{{ .MediaProgression }}"
+                {{ if $.user }}data-last-position="{{ .MediaProgression }}"{{ end }}
                 {{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }}
                 {{ if $.user.MarkReadOnMediaPlayerCompletion }}
                     data-mark-read-on-completion="0.9"
                 {{ end }}
-                data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"
+                {{ if $.user }}data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"{{ end }}
                 data-enclosure-id="{{.ID}}"
                 >
                 {{ if (and $.user (mustBeProxyfied "audio")) }}
@@ -244,12 +244,12 @@ <h1 id="page-header-title" dir="auto">
         {{ else if hasPrefix .MimeType "video/" }}
         <div class="enclosure-video">
             <video controls preload="metadata"
-                data-last-position="{{ .MediaProgression }}"
+                {{ if $.user }}data-last-position="{{ .MediaProgression }}"{{ end }}
                 {{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }}
                 {{ if $.user.MarkReadOnMediaPlayerCompletion }}
                     data-mark-read-on-completion="0.9"
                 {{ end }}
-                data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"
+                {{ if $.user }}data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"{{ end }}
                 data-enclosure-id="{{.ID}}"
                 >
                 {{ if (and $.user (mustBeProxyfied "video")) }}