Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Backport changes and extensions from Minetest #159

Open
numberZero opened this issue Feb 18, 2023 · 5 comments
Open

Backport changes and extensions from Minetest #159

numberZero opened this issue Feb 18, 2023 · 5 comments
Labels

Comments

@numberZero
Copy link
Contributor

numberZero commented Feb 18, 2023

These were added before forking Irrlicht. Currently there is no point keeping them separate.

See also: minetest/minetest#13227

@numberZero numberZero changed the title Backport irrlicht_changes from Minetest Backport changes and extensions from Minetest Feb 18, 2023
@sfan5
Copy link
Member

sfan5 commented Feb 19, 2023

This should be all that's left:

Not sure if it makes sense to move the src/gui/ stuff to Irrlicht either since it might be too integrated to MT.
In fact it might not make sense to move anything back since Irrlicht is supposed to merged into MT not the other way around.

@numberZero
Copy link
Contributor Author

If the GUI stuff is all that is there, it may indeed make more sense to to move in the opposite direction: move all GUI stuff that MT still uses into MT, and drop GUI part here altogether.

@numberZero
Copy link
Contributor Author

numberZero commented Mar 13, 2023

There is also src/irrlichttypes.h:

  • irr::core::roundingError<s16> ()
  • *_MIN, *_MAX

src/irrlicht_changes is GUI stuff only so it should likely merged into src/gui.

@Desour
Copy link
Member

Desour commented Mar 14, 2023

irr_ptr would be good to have in irrlicht.

@numberZero
Copy link
Contributor Author

irr_ptr would be good to have in irrlicht.

Makes sense. For the API I’d wait for The Merge but for internal use, it’s OK to start using it now IMO. My grep suggests there are 287 drop calls and 89 grab calls awaiting replacement.

@sfan5 sfan5 added the Roadmap label Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants