Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for managing team settings #64

Open
bodgit opened this issue Feb 23, 2023 · 0 comments
Open

Add support for managing team settings #64

bodgit opened this issue Feb 23, 2023 · 0 comments

Comments

@bodgit
Copy link

bodgit commented Feb 23, 2023

There is a github_team_settings resource for (currently) controlling review request delegation. It is configured like so:

resource "github_team_settings" "code_review_settings" {
  team_id = github_team.some_team.id

  review_request_delegation {
    algorithm    = "ROUND_ROBIN"
    member_count = 1
    notify       = true
  }
}

I propose adding an additional module input, either something like:

module "some_team" {
   ...

  review_request_delegation = {
     ...
  }
}

or

module "some_team" {
  ...

  settings = {
    review_request_delegation = {
      ...
    }
  }
}

(should the github_team_settings resource gain more arguments)

The presence of this variable being non-null creates a github_team_settings resource. Happy to send a PR if you think that would be acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant