Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x - Drop support for PHP <= 8.1 #6

Open
Sweetchuck opened this issue Feb 21, 2024 · 2 comments
Open

2.x - Drop support for PHP <= 8.1 #6

Sweetchuck opened this issue Feb 21, 2024 · 2 comments

Comments

@Sweetchuck
Copy link
Contributor

Sweetchuck commented Feb 21, 2024

A little refactor.

A new branch is needed to create a pull request.
https://github.com/Sweetchuck/mindscreen-yarnlock/tree/2.x

@PRGfx
Copy link
Member

PRGfx commented Feb 22, 2024

Thank you for your work. You suggest a "2.x" branch (as new default branch)? I would wait for #5 with that and create it off that.

I will look through your changes if there is a PR then, but can you maybe outline how (much) this is breaking existing interfaces?
As PHP < 8.1 is EOL, I don't see additional 1.x changes, i.e. I would just tag the releases and continue with 2.x. For now I'm not yet convinced to maintain separate branches – if need be I guess we could branch off of a 1.x tag..

@PRGfx
Copy link
Member

PRGfx commented Feb 29, 2024

I tagged the presumably last 1.x release and created a 2.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants