Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [bitset] extend op_find() to be able to search both 0 and 1 #39176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexanderguzhva
Copy link
Contributor

issue: #39124

bitset::find_first() and bitset::find_next() now accept one more parameter, which allows to search for 0 bit instead of 1 bit

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/compilation labels Jan 12, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 12, 2025
Copy link
Contributor

mergify bot commented Jan 12, 2025

@alexanderguzhva

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@alexanderguzhva alexanderguzhva changed the title bitset: extend op_find() to be able to search both 0 and 1 enhance: [bitset] extend op_find() to be able to search both 0 and 1 Jan 12, 2025
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Jan 12, 2025
Copy link
Contributor

mergify bot commented Jan 12, 2025

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (a8a6564) to head (3cde19a).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39176       +/-   ##
===========================================
+ Coverage   69.64%   81.16%   +11.52%     
===========================================
  Files         296     1395     +1099     
  Lines       26633   197393   +170760     
===========================================
+ Hits        18548   160216   +141668     
- Misses       8085    31560    +23475     
- Partials        0     5617     +5617     
Components Coverage Δ
Client 79.53% <ø> (∅)
Core 69.68% <100.00%> (+0.03%) ⬆️
Go 83.10% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/bitset/bitset.h 99.41% <100.00%> (ø)
internal/core/src/bitset/detail/bit_wise.h 100.00% <100.00%> (ø)
...ternal/core/src/bitset/detail/element_vectorized.h 100.00% <100.00%> (ø)
internal/core/src/bitset/detail/element_wise.h 99.24% <100.00%> (+0.07%) ⬆️
internal/core/src/bitset/detail/proxy.h 100.00% <ø> (ø)

... and 1099 files with indirect coverage changes

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 12, 2025

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 13, 2025

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@liliu-z
Copy link
Member

liliu-z commented Jan 13, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liliu-z
Copy link
Member

liliu-z commented Jan 13, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 13, 2025

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants