Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to webpack 2 #71

Open
rmoorman opened this issue Apr 12, 2017 · 6 comments
Open

Update to webpack 2 #71

rmoorman opened this issue Apr 12, 2017 · 6 comments

Comments

@rmoorman
Copy link

Hello,

I am currently using this plugin to output SRI information to a separate file. Sadly, the current version on npm does not support webpack 2.
However there is a fork over at @sopherio which contains changes from @sechel that seem to work for webpack 2. Could those be merged and released to npm?

Thank you very much in advance!

Best regards,
Rico

@sechel
Copy link

sechel commented Apr 13, 2017

Hey Rico,
why don't you just do this:

"devDependencies": {
  "sri-stats-webpack-plugin": "github:sopherio/sri-stats-webpack-plugin"
}

It's not optimal in the sense that you do not have the full control over the version but in this case this seems not too bad. If you are worried, you could even fork ours and be safe.
Greetings
Stefan

@rmoorman
Copy link
Author

rmoorman commented Apr 13, 2017

@sechel thank you for the suggestion and I am actually already using this inside of my package.json :-)

"sri-stats-webpack-plugin": "github:sopherio/sri-stats-webpack-plugin#f23de19e1d84dab50e59076e05bcafa508ba64c4"

As for opening this issue here, it looked to me that this is the repo behind the version on npm which is what folks would normally use (upstream?) and I thought it could be a good thing to combine the efforts and keep the package up to date on npm :-)

@sechel
Copy link

sechel commented Apr 13, 2017

You are right, it's always good to have it on npmjs.com. Thats where folks (and npm) search for things, and its even better since they decided to make organizations free :-) Big Up!

@ajsharp
Copy link

ajsharp commented May 17, 2017

@mikechau Any plans to support this?

@mikechau
Copy link
Owner

Hi @ajsharp, yeah I will look into it this weekend. Currently the test is failing on custom-stats-patch: mikechau/webpack-custom-stats-patch#49 (comment) and would like to resolve it before updating this package.

@mvastola
Copy link

Just a gentle ping to see if there has been (or is going to be) any movement on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants