-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facilitate deletion of VeleroBackup object via NAB object #58
Comments
We also need similar logic for Restores ❓ |
yes definitely |
I was not sure about that. If we delete VeleroBackup won't we have problem with restore? I thought that VeleroBackup should not get deleted so it can be restored when namespace which includes NAB gets deleted as an example? |
If the NAB object that created the VeleroBackup object gets deleted then the corresponding VeleroBackup should also get deleted, right ? |
Non-Admin restores will be referring non-admin backups and not VeleroBackup objects |
Ok, but isn't VeleroBackup required to be on cluster to perform Restore operation? If not and we only need to know the name of the original VeleroBackup object stored in S3 or other storage then we are safe to delete. |
yes VeleroBackup is needed for restore but we are not talking about performing a restore operation here, We are saying if a non-admin backup is deleted by the user then let's delete its corresponding VeleroBackup. There might be a scenario where we do not want to do this when the namespace deletion would trigger the NAB deletion and subsequently VeleroBackup deletion, we might need to somehow different between these 2 scenarios. |
If we do not delete Velero Backup when deleting NAB, sync controller will recreate it, right ❓ this would mean, in the end, that non admin users can not delete their backups, right ❓ |
There are most likely 2 cases when NAB CR gets deleted:
One way of solving this for both cases would a user input opt-in based deletion. By default the NAB CR has an annotation applied by our NAB controller like |
I would prefer that the mechanism be an actual spec field. This will allow us to version this field, which can become important in the future. |
If we add finalizer to NAB then we will have time to check if namespace was deleted as well, or just the NAB. Then we can automate from there either velero backup deletion or honor annotation/spec to preserve velero backup for NAB recreation on namespace recreation. |
Enhancement which will delete original VeleroBackup when the user sets the deleteVeleroBackup witin NonAdminBackup Spec. Fixes Issue migtools#58 Signed-off-by: Michal Pryc <[email protected]>
Enhancement which will delete original VeleroBackup when the user sets the deleteVeleroBackup witin NonAdminBackup Spec. Fixes Issue migtools#58 Signed-off-by: Michal Pryc <[email protected]>
Enhancement which will delete original VeleroBackup when the user sets the deleteVeleroBackup witin NonAdminBackup Spec. Fixes Issue migtools#58 Signed-off-by: Michal Pryc <[email protected]>
Enhancement which will delete original VeleroBackup when the user sets the deleteVeleroBackup witin NonAdminBackup Spec. Fixes Issue migtools#58 Signed-off-by: Michal Pryc <[email protected]>
Enhancement which will delete original VeleroBackup when the user sets the deleteVeleroBackup witin NonAdminBackup Spec. Fixes Issue migtools#58 Signed-off-by: Michal Pryc <[email protected]>
Enhancement which will delete original VeleroBackup when the user sets the deleteVeleroBackup witin NonAdminBackup Spec. Fixes Issue migtools#58 Signed-off-by: Michal Pryc <[email protected]>
Signed-off-by: Michal Pryc <[email protected]>
Signed-off-by: Michal Pryc <[email protected]>
No description provided.
The text was updated successfully, but these errors were encountered: