Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excluded resources potential api conflict #808

Open
kaovilai opened this issue Apr 19, 2022 · 1 comment
Open

Excluded resources potential api conflict #808

kaovilai opened this issue Apr 19, 2022 · 1 comment

Comments

@kaovilai
Copy link
Member

Not from any live cases but I feel current code can result in some Kinds unintentionally excluded by default.
https://github.com/konveyor/mig-operator/blob/f185b25483ca75720cee934d1cb106aaa61fb276/roles/migrationcontroller/defaults/main.yml#L8-L22

I can see things like subscriptions.operators.NOTcoreos.com being problematic.. so maybe we should use full api name in this list.

Something like

  - imagetags.image.openshift.io
  - templateinstances.template.openshift.io
  - clusterserviceversions.operators.coreos.com
  - packagemanifests.packages.operators.coreos.com
  - subscriptions.operators.coreos.com
@kaovilai kaovilai mentioned this issue Apr 20, 2022
Closed
@jmontleon
Copy link
Collaborator

Yes, I'm open to this as long as it works and is tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmontleon @kaovilai