Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling on the flask backend #561

Open
jayantbh opened this issue Oct 1, 2024 · 5 comments
Open

Improve error handling on the flask backend #561

jayantbh opened this issue Oct 1, 2024 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code

Comments

@jayantbh
Copy link
Contributor

jayantbh commented Oct 1, 2024

Description:

Right now errors from the flask backend are often returned as HTML errors instead of a more system parseable JSON style error.

We should change that such that flash returns errors as JSON instead.
https://flask.palletsprojects.com/en/2.3.x/errorhandling/
@jayantbh jayantbh added bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code hacktoberfest labels Oct 1, 2024
@dominicghizzoni
Copy link

could you assign this to me?

@jayantbh
Copy link
Contributor Author

jayantbh commented Oct 2, 2024

Sure, @dominicghizzoni

dominicghizzoni added a commit to dominicghizzoni/middleware that referenced this issue Oct 3, 2024
@dominicghizzoni
I modified app.py to make changes mentioned in issue middlewarehq#561
4d119b0
@dominicghizzoni dominicghizzoni mentioned this issue Oct 3, 2024
Closed
@larrikin-coder
Copy link

is te issue still open @dominicghizzoni ? If it is please assign me this issue.

@dominicghizzoni
Copy link

is te issue still open @dominicghizzoni ? If it is please assign me this issue.

yes you may continue my work on it

@jayantbh
Copy link
Contributor Author

@larrikin-coder, there's an existing PR for it, #567
You may decide to continue on that (or look at the review already done on that) as a starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayantbh @larrikin-coder @dominicghizzoni