-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization header in large file upload slices causing failures #2026
Comments
Hi @qiurunxing Thanks for raising this issue and the detailed logs. This seems to be a change on the API side causing this and not a change on the SDK. If it's ok with you, may I redirect you to post this issue on Microsoft Q&A so that the OneDrive API team looks into this. We also have a new version of the SDK |
Hi @Ndiritu Thank you for your quick reply. Please help redirect to the API team, thanks! |
@qiurunxing created the issue on Q&A for you. You'd need to sign-in and |
Thanks @Ndiritu. |
@qiurunxing I'm not sure why it's been taken down. But yes, you can create the issue yourself so that you get notified about responses and requests for more info. |
Thanks @Ndiritu. |
We faced the same issue, which turned out to be caused by including an authorization header in the upload task.
So, the solution can be to create a separate |
|
Thank you for pointing this out @DamianNowak5f. An alternative work-around is to set the requestAdapter property to Adding this to our backlog to make this experience better. |
I believe this should be resolved with the latest version of the SDK and can be closed. With the |
Thanks @andrueastman @DamianNowak5f @Ndiritu But I'm curious that this issue is only reproduce on some accounts. Only some accounts can reproduce, but we noticed that the URL uploaded by the abnormal accounts is "https://my.microsoftpersonalcontent.com/personal....", and the upload URL used by the available accounts is "https://api.onedrive.com/rup/....", and the upload URL is from UploadSession. |
Its possible that one account is a MSA(personal) account while the other are school/work account. OneDrive Apis do behave differently based on the account types due to various reasons. I believe the right thing to do is to always ensure the Auth header is not set. As the URL is not a graph API URL so the token would be invalid either way as the host is different from the token issuer, and the request should ideally fail. |
|
Ok |
Expected behavior
We've been using this feature for a long time and in recent days we've noticed that some accounts can't upload files, but some do. We expect file uploads to work for all accounts.
microsoft-graph: 2.10.0
Actual behavior
Steps to reproduce the behavior
Only some accounts can reproduce, but we noticed that the URL uploaded by the abnormal accounts is
https://my.microsoftpersonalcontent.com/personal
, and the upload URL used by the available accounts ishttps://api.onedrive.com/rup/
, and the uploaded URL is from UploadSession.I'm a little curious as to why there is such a difference.
The text was updated successfully, but these errors were encountered: