-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Package Issue]: Gyan.FFmpeg sets environment path incorrectly #95349
Comments
This is because ffmpeg is a library and not truly a portable application or portable installer Blocked by microsoft/winget-cli#2711 |
Interesting. I wonder if it's due to path cramming differences between user/admin and whether or not developer mode is enabled. Might have something to do with symlink creation |
Doesn't work for me, I had to explicitly put The normal environment path has nothing but that |
I believe you need to fully close all previous terminals, then open a new one for it to actually refresh. Hence why it's not in your PATH yet. |
Doesn't work for me.
Simply opening User Variable Path edit dialog and then clicking on "OK"s twice also resolves the issue. |
For me, I also tried undoing my change and just opening and hitting save twice, and still nothing. |
The pkg being downloaded is ffmpeg-5.1.2-full_build.zip which contains three statically linked i.e. standalone bnaries. P.S. The PackageName in the locale files should be corrected to just FFmpeg. |
My mistake, I was misunderstanding between multiple issues |
I think the package names require authors, and therefore it should be Gyan.FFmpeg as it is now. Theoretically, it could be FFmpeg.FFmpeg, however, FFmpeg did not author the builds themselves. |
I'm referring to PackageName, not PackageIdentifier. 'Codex FFmpeg' is the name of my site. The package is simply 'FFmpeg;'. |
Ahh my mad. I do agree with this. |
I forgot to change the PackageName and have opened a PR for this 😂: |
I have the exact same problem. This was added my PATH: |
I have developer mode enabled, and it works for me. A symlink is added to |
What "developer mode" are you referring to? Is this a winget-cli thing? A powershell thing? Windows itself? |
See https://learn.microsoft.com/en-us/windows/apps/get-started/enable-your-device-for-development. Yes, it is a Windows thing. The important thing that you need to know is that creating symlinks normally require admin previlages, and developer mode bypasses that: I'm thinking the "Add binary directory to PATH directly" is a fallback to non-admin and non-developer mode machines. Try enabling it and see if it resolves your problem. |
Ok, I'll try that. But even if it would fix my problem, there is still a bug at work here, no? The directory path being added to PATH on non-developer mode machines should not be incomplete... |
I am now able to replicate this bug by turning off developer mode. Note that |
This bug should only affect people without developer mode enabled and don't have admin previlages. |
This same issue is happening with |
I also ran into this issue. Fresh Win11 install, unelevated, no developer mode.
Closed and opened the terminal, then checked the path:
Going deeper into the path, at
edit: Running uninstall also does not remove it from the path. |
Same here |
Resolved in WinGet v1.5.1081-preview release |
It may be a bug. For now, try |
Close with reason: Stated above; |
I tried with the prerelease winget, doesn't solve for me. |
Same here... |
@rvxfahim Did you already have an installation of ffmpeg from an older version of WinGet? @GavinRay97 @brizolara Can you please share the version of WinGet you are running from |
@mdanish-kh Certainly, thanks for the swift reply (and on a weekend, no less) S C:\Users\rayga> winget -v
v1.4.11071 I suspect this is because of your earlier comment:
Sorry, I should have double-checked my version. For some reason I thought WinGet auto-updated. |
@GavinRay97 No worries :) Note that an uninstall would be required first to benefit from the fix. I would advise uninstalling the package first from WinGet 1.4 (if you haven't upgraded already) as there's a bug currently in the preview version where the uninstall command gets stuck infinitely for these packages if there is a prior installation from WinGet 1.4. (microsoft/winget-cli#3279) If you have upgraded though, the most convenient workaround I've found is to downgrade to WinGet 1.4 (i.e. download and install msix from https://github.com/microsoft/winget-cli/releases/download/v1.4.10173/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle), force uninstall the package using |
yes, I installed 1.4 then force uninstalled and then installed preview version of winget and then installed ffmpeg. Now it works |
can confirm I still get this bug as of June of 2023. winget version is "v1.4.11071"
So, if you installed ffmpeg using winget with no admin nor developer mode enabled, I'd recommend you |
Confirmed issue and solution for 6.0 |
Why was this closed? I have the same issue. It added the path two directories up to PATH instead of the bin directory |
@B4ttleMast0r I had the same problem as you, but it was because I didn't carefully read the all the messages in this thread. It is fixed only if you installed FFmpeg with winget 1.5+. It has been in release candidate stage for almost a month so hopefully they can push it to GA soon and us poor folks will stop cutting our metaphorical fingers on this issue. |
works for me, thank you. |
+1, Same error: as workaround:
|
For me, I found out that I wasn't running winget as admin. It got installed but no environment variables can be added. |
Still not working for me with fresh install on Windows 11 22H2 Error:
|
I uninstalled the package and reinstalled as admin, then the PATH was actually updated. |
I recently clean installed Windows 11 with the latest Media Creation Tool -> USB. I did |
This is not fixed with the latest version of winget. When I installed ffmpeg it was fine, but today I upgraded it and ffmpeg got removed from PATH. I had to add it manually. Maybe should be merged with #120360. |
when you used command: "winget install ffmpeg" resolution: run sysdm.cply updated Sep.14 2024. |
thank you @dave2nian, I was trying to figure out where the binary was after using winget. |
Please confirm these before moving forward
Category of the issue
Installation issue.
Brief description of your issue
The ffmpeg, ffprobe, and ffplay aliases do not work even after restarting shell due to the environment path being wrong.
The environment path added was
C:\Users\...\AppData\Local\Microsoft\WinGet\Packages\Gyan.FFmpeg_Microsoft.Winget.Source_8wekyb3d8bbwe
but it needs to beC:\Users\...\AppData\Local\Microsoft\WinGet\Packages\Gyan.FFmpeg_Microsoft.Winget.Source_8wekyb3d8bbwe\ffmpeg-5.1.2-full_build\bin
before it works.Steps to reproduce
winget install ffmpeg
ffmpeg --help
, it will fail and say it's unrecognisedActual behavior
the
ffmpeg
,ffplay
, andffprobe
aliases are not recognizedExpected behavior
They should be found and refer to the binary.
Environment
Screenshots and Logs
The text was updated successfully, but these errors were encountered: