Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Request]: ctrl-f.userdiag 24.1.17 #136463

Closed
SkyEmie opened this issue Jan 25, 2024 · 4 comments · Fixed by #136739
Closed

[Update Request]: ctrl-f.userdiag 24.1.17 #136463

SkyEmie opened this issue Jan 25, 2024 · 4 comments · Fixed by #136739
Labels
In-PR Needs-Attention This work item needs to be reviewed by a member of the core team. Package-Update This package needs to be updated
Milestone

Comments

@SkyEmie
Copy link
Contributor

SkyEmie commented Jan 25, 2024

What type of update are you requesting?

A new version of an existing package

Current Package Identifier

ctrl-f.userdiag

Package Version

24.1.18

Please describe the changes you would like to see

New version: 24.1.18
Installer URL: https://userdiag.com/download?winget

@SkyEmie SkyEmie added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated labels Jan 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 25, 2024
@Trenly
Copy link
Contributor

Trenly commented Jan 26, 2024

@SkyEmie - Is there some form of UserAgent or Client check which could be preventing WinGet from being able to access the URL?

Found UserDiag [ctrl-f.userdiag] Version 24.1.17
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://userdiag.com/download?WinGet
An unexpected error occurred while executing the command:
Download request status is not success.
0x80190193 : Forbidden (403).

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 26, 2024
@stephengillie
Copy link
Collaborator

Yes, WinGet uses its own User-Agent string, which some hosts have started blocking. This allows them to prevent automated downloads but still allow user downloads through the browser.

The InstallerUrl here appears to use a JavaScript function to gather details about the browser, to prevent automated downloads. WinGet probably doesn't invoke a full browser for downloads, and instead probably performs a simple GET. This is a different method from above, and is just as effective.

Packages on this host might not be a good fit for inclusion into the WinGet public manifests.

@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 26, 2024
@SkyEmie
Copy link
Contributor Author

SkyEmie commented Jan 27, 2024

I've updated the link (?winget instead of ?WinGet)
It doesn't seem to be a problem now

emie@desktop-8sonn9n:~$ curl -I https://userdiag.com/download?winget
HTTP/1.1 200 OK
Date: Sat, 27 Jan 2024 00:40:24 GMT
Content-Type: application/octet-stream
Content-Length: 939952
Connection: keep-alive
content-description: File Transfer
content-disposition: attachment; filename=ud_winget.exe
content-transfer-encoding: binary
expires: 0
Cache-Control: no-store
strict-transport-security: max-age=0
referrer-policy: strict-origin-when-cross-origin
x-xss-protection: 1; mode=block
x-frame-options: sameorigin
x-content-type-options: nosniff
x-permitted-cross-domain-policies: none
CF-Cache-Status: DYNAMIC

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added In-PR and removed Help-Wanted This is a good candidate work item from the community. labels Jan 27, 2024
@Trenly
Copy link
Contributor

Trenly commented Jan 30, 2024

I've updated the link (?winget instead of ?WinGet) It doesn't seem to be a problem now

emie@desktop-8sonn9n:~$ curl -I https://userdiag.com/download?winget
HTTP/1.1 200 OK
Date: Sat, 27 Jan 2024 00:40:24 GMT
Content-Type: application/octet-stream
Content-Length: 939952
Connection: keep-alive
content-description: File Transfer
content-disposition: attachment; filename=ud_winget.exe
content-transfer-encoding: binary
expires: 0
Cache-Control: no-store
strict-transport-security: max-age=0
referrer-policy: strict-origin-when-cross-origin
x-xss-protection: 1; mode=block
x-frame-options: sameorigin
x-content-type-options: nosniff
x-permitted-cross-domain-policies: none
CF-Cache-Status: DYNAMIC

Looks like they might be blocking additional user agents now - #136739 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Needs-Attention This work item needs to be reviewed by a member of the core team. Package-Update This package needs to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants