Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Azure Pipelines failing on manifest that contains dependencies #135625

Open
Cyberboss opened this issue Jan 20, 2024 · 6 comments
Open
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@Cyberboss
Copy link
Contributor

I'm facing an unknown issue preventing my package from being validated. Refer to #132245, #133023, and #135613.

I recently ran a test to prove a change in my package wasn't a change in my code. 6.1.0 was originally submitted in #132002 and validated successfully. The exact same manifest (and therefore, installer) with a different version number failed validation today (#135622).

I am unable to diagnose this issue further do to the validation logs seemingly being unavailable to the public.

Copy link
Contributor

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@Cyberboss Cyberboss changed the title There is an issue with package validation that wasn't previously present. No logs present to diagnose There is an issue with package validation Azure Pipeline that wasn't previously present. No logs present to diagnose Jan 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 20, 2024
@Trenly
Copy link
Contributor

Trenly commented Jan 20, 2024

It looks like this is an issue with the dependencies -

2024-01-20 20:20:14.526 [CORE] WinINet downloading from url: https://cdn.winget.microsoft.com/cache/manifests/m/Microsoft/DotNet/HostingBundle/8/8.0.1/f982
2024-01-20 20:20:14.542 [CORE] Download hash: bbb67cb3c8300f8168edf9863a74028a873ebe614773b03df4652af2d7855160
2024-01-20 20:20:14.542 [CORE] Download completed.
2024-01-20 20:20:14.543 [CLI ] Starting installer selection.
2024-01-20 20:20:14.543 [CLI ] Installer [X86,burn,Unknown,] not applicable: Installer locale does not match required locale: Required locales: [en-us] Or does not satisfy compatible match for Preferred Locales: [en-US]
2024-01-20 20:20:14.543 [CLI ] Installer [X86,burn,Unknown,] not applicable: Installer scope does not match required scope: Unknown != Machine
2024-01-20 20:20:14.545 [CLI ] No suitable installer found for manifest Microsoft.DotNet.HostingBundle.8 with version 8.0.1

The full InstallationVerification logs are available in the Validation Pipeline - https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=533897&view=artifacts&pathAsName=false&type=publishedArtifacts

You can get there by going to your PR, clicking on "Checks", then "Azure Pipelines" => "WinGetSvc-Validation" => "View more details on Azure Pipelines" and then looking for the "Artifacts"

image

@Trenly
Copy link
Contributor

Trenly commented Jan 20, 2024

@denelon - looks like Unknown isn't being considered applicable for dependencies, when it really should be

Cyberboss added a commit to tgstation/tgstation-server that referenced this issue Jan 20, 2024
We already provide this package in the installer so it's actually not a dependency.

Refer to microsoft/winget-pkgs#135625
@Cyberboss
Copy link
Contributor Author

Thanks for pointing that out. Knowing it's the dependency spec, I can actually remove that since it's a bundled .msi in my installer.

I assume you want me to leave this issue open to triage the pipelines issue?

@stephengillie stephengillie added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Jan 22, 2024
@Cyberboss Cyberboss changed the title There is an issue with package validation Azure Pipeline that wasn't previously present. No logs present to diagnose Regression: Azure Pipelines failing on manifest that contains dependencies Jan 22, 2024
@Cyberboss
Copy link
Contributor Author

Updated title appropriately. Note that this used to work fine last year

@dougmassay
Copy link
Contributor

Any more on this? I'm getting similar inexplicable failures with a manifest that has a microsoft.VCRedist.2015+.x64 dependency.

#147284 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

4 participants