Terminal executable does not check path if a dir of the same name exists at the cwd

[Tyriar]

Context dotnet/vscode-csharp#3372 (comment)

Repro:

1. Have dotnet in $PATH
2. Open a folder
3. Create a dotnet folder inside the root
4. Set the terminal shell as dotnet

[joyceerhl]

@Tyriar what are some verification steps for this?

[Tyriar]

@joyceerhl the steps above in #83772 (comment), just open a terminal at the end and make sure it works

[joyceerhl]

I'm not totally sure what step 4 is about, I created a terminal and ran the dotnet command

[Tyriar]

@joyceerhl oh ok, it's using old terminology. You need to create and launch this profile:

  "terminal.integrated.profiles.windows": {
    "dotnet": {
      "path": "dotnet"
    }
  }

[joyceerhl]

When creating and launching that profile with dotnet in the path I see a terminal get created, then it immediately closes and I get this error notification:

[Tyriar]

Oh ok 🤷, but it still fixed the bug as it's picking it up off the path, not the workspace folder