Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom powerline git, ln and lock symbols #214142

Closed
Tyriar opened this issue Jun 3, 2024 · 6 comments · Fixed by #214150
Closed

Custom powerline git, ln and lock symbols #214142

Tyriar opened this issue Jun 3, 2024 · 6 comments · Fixed by #214150
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 3, 2024

Upcoming change from xterm.js xtermjs/xterm.js#5054

Before (with a font NOT containing powerline symbols):

image

Before (with a font containing powerline symbols):

image

After:

image

Zoomed:

image

Big letter spacing and line height:

image

@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Jun 3, 2024
@Tyriar Tyriar added this to the June 2024 milestone Jun 3, 2024
@Tyriar Tyriar self-assigned this Jun 3, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Jun 3, 2024

To verify in powershell:

Run:

"`u{e0a0} `u{e0a1} `u{e0a2}"

Verify symbols appear

Change terminal line height and letter spacing, verify the symbols rescale.

Tyriar added a commit that referenced this issue Jun 3, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 3, 2024
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jun 24, 2024
@alexr00
Copy link
Member

alexr00 commented Jun 25, 2024

I must be doing something wrong:

image

@Tyriar
Copy link
Member Author

Tyriar commented Jun 25, 2024

@alexr00 is that pwsh 7 and Windows 11?

@andreamah andreamah added the verified Verification succeeded label Jun 25, 2024
@andreamah
Copy link
Contributor

image
seems to work for me

@alexr00
Copy link
Member

alexr00 commented Jun 26, 2024

@Tyriar apparently it was version 5:

PS C:\Users\alros\repos\Microsoft\vscode> $PSVersionTable.PSVersion

Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      22621  3672    

@Tyriar
Copy link
Member Author

Tyriar commented Jun 26, 2024

@alexr00 ah ok, it likely only works on pwsh 6 or 7+

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants