-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2023.12.0 - Testing Tab - pytest no results with VCR --block-network #21645
Comments
Thank you for your issue report. We are looking into this now! In the meantime, you are likely on the new testing rewrite and this is why you saw a change in behavior since we just moved to this experiment to a larger group of people receiving it. You can opt out of the rewrite as I get this fix in by setting this in your user settings: |
@eleanorjboyd that was it! works like I expect now on Thanks! happy to help if there's anything else I can test; otherwise, feel free to close. |
Looks like the test got expanded even further. Another one of our engineers in Vietnam hit this issue yesterday as mentioned in #22192. We thought it might be related but guess not. While it looks like that issue was fixed, I tested just now and ours still persists. If I remove Happy to test anyway I can. |
Hi @nitsujri, are you still seeing this? If so can you set log level to trace (via the command palette "developer: set log level...) and then set me the logs to the "python" output channel. Also a description of your workspace setup would be helpful. Thanks |
Thanks so much! Running the latest pre-release Test Result Tab
Output of Python - Trace level
|
@eleanorjboyd oh i found it! it's related to the original problem If I remove this from my The specific library we're using for this function: https://github.com/kiwicom/pytest-recording |
aha great find! What is your use case for |
seems the same issue as #22383, around network settings. Lmk if you think they are different. If you think they are the same I might close this one to keep the conversation in one place and move it there. Thanks |
IMO, they're the same underlying problem. Both pytest_socket and pytest-recording block networking the same way: by monkey-patching |
ok then lets close this issue and move all conversation there on if there is a solution to both these networking conflicts. Thanks |
Type: Bug
Behaviour
Expected vs. Actual
VSCode's Test panel results no longer report test results after upgrading to version
2023.12.0
.Reproducibly works in
2023.10.1
Steps to reproduce:
2023.12.0
), pytest (7.4.0), pytest-recording.2023.10.1
(must click onTesting
tab after reloading VSCode to pickup specs).[UPDATE] I discovered I have to go back to
2023.08.0
to get the proper output otherwise, see images below:2023.10.1 - Broken output "Passed here" repeated
2023.08.0 - Proper working output
Diagnostic data
python.languageServer
setting: DefaultOutput for
Python
in theOutput
panel (View
→Output
, change the drop-down the upper-right of theOutput
panel toPython
)User Settings
Extension version: 2023.10.1
VS Code version: Code 1.80.1 (Universal) (74f6148eb9ea00507ec113ec51c489d6ffb4b771, 2023-07-12T17:20:23.298Z)
OS version: Darwin arm64 22.5.0
Modes:
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
A/B Experiments
The text was updated successfully, but these errors were encountered: