Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #1247

Closed
3 of 4 tasks
bpavo opened this issue Sep 30, 2023 · 3 comments
Closed
3 of 4 tasks

Bug #1247

bpavo opened this issue Sep 30, 2023 · 3 comments

Comments

@bpavo
Copy link

bpavo commented Sep 30, 2023

Environment:

  • VS Code Version:
  • Extension Version:
  • JDK Type & Version:
  • OS Type & Version:

Step to Reproduce:

Expected Behavior:

Actual Behavior:

Related Issues:

Tasks

  1. needs more info
  2. needs more info

Tasks

No tasks being tracked yet.
@bpavo
Copy link
Author

bpavo commented Sep 30, 2023

package mediawiki

import (
"fmt"
"io/ioutil"
"net/http"
"net/http/httptest"
"net/url"
"strings"
"testing"
)

const (
editTokenReponse = {"query":{"pages":{"15580374":{"pageid":15580374,"ns":0,"title":"Main Page","contentmodel":"wikitext","pagelanguage":"en","touched":"2013-11-02T14:08:05Z","lastrevid":574690625,"counter":"","length":6391,"starttimestamp":"2013-11-02T15:24:43Z","edittoken":"+\\","revisions":[{"revid":574690625,"parentid":574690493,"minor":"","user":"Tariqabjotu","timestamp":"2013-09-27T03:10:17Z","comment":"removing unnecessary pipe"}]}}}}
firstLogin = {"login":{"result":"NeedToken","token":"8f48670ddc7fa9d5fa7e7fa2ae147e80","cookieprefix":"wikidb","sessionid":"927e0d298f6f3b5bb21228803fd9c0eb"}}
secondLogin = {"login":{"result":"Success","token":"8f48670ddc7fa9d5fa7e7fa2ae147e80","cookieprefix":"wikidb","sessionid":"927e0d298f6f3b5bb21228803fd9c0eb"}}
failedLogin = {"login":{"result":"ERROR THING","token":"8f48670ddc7fa9d5fa7e7fa2ae147e80","cookieprefix":"wikidb","sessionid":"927e0d298f6f3b5bb21228803fd9c0eb"}}
readPage = {"query-continue":{"revisions":{"rvcontinue":574690493}},"query":{"pages":{"15580374":{"pageid":15580374,"ns":0,"title":"Main Page","revisions":[{"user":"Tariqabjotu","timestamp":"2013-09-27T03:10:17Z","comment":"removing unnecessary pipe","contentformat":"text/x-wiki","contentmodel":"wikitext","*":"FULL PAGE TEXT"}]}}}}
fileURL = {"query":{"pages":{"107":{"pageid":107,"ns":6,"title":"File:stuff.pdf","imagerepository":"local","imageinfo":[{"url":"%s","descriptionurl":"TEST"}]}}}}
fileURLFailed = {"query":{"pages":{"544100":{"pageid":544100,"ns":0,"title":"Asdf"}}}}
mwerror = {"servedby":"mw1123","error":{"code":"unknown_action","info":"Unrecognized value for parameter 'action': blah"}}
editsuccess = {"Edit":{"result":"Success","pageid":12,"title":"Talk:Main Page","oldrevid":465,"newrevid":471}}
editfailure = {"Edit":{"result":"Failure!","pageid":12,"title":"Talk:Main Page","oldrevid":465,"newrevid":471}}
)

type Test struct {
ts *httptest.Server
client *MWApi
}

func (t *Test) TearDown() {
t.ts.Close()
}

func BuildUp(response string, t *testing.T) *Test {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
fmt.Fprintln(w, response)
}))
client, err := New(ts.URL, "TESTING")
if err != nil {
t.Fatalf("Error in BuildUp: %s", err)
}
return &Test{ts: ts, client: client}
}

func TestGetEditToken(t *testing.T) {
test := BuildUp(editTokenReponse, t)
defer test.TearDown()

err := test.client.GetEditToken()
if err != nil {
	t.Errorf("Could not get edit token: %s", err.Error())
} else {
	t.Log("Got edit token")
}
if test.client.edittoken == `+\` {
	t.Log("Edit token correct")
} else {
	t.Errorf("Incorrect edit token: %s", test.client.edittoken)
}

}

func TestLogin(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
panic(err)
}
if r.Form.Get("lgtoken") == "" {
fmt.Fprintln(w, firstLogin)
} else {
fmt.Fprintln(w, secondLogin)
}
}))
defer ts.Close()
client, err := New(ts.URL, "TESTING")
if err != nil {
t.Fatalf("Error creating client: %s", err.Error())
}
client.Domain = "asdf"
err = client.Login("asdf", "asdf")
if err != nil {
t.Errorf("Client failed to login: %s", err)
} else {
t.Log("Client logged in successfully.")
}
}

func TestLoginFailedSecondary(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
panic(err)
}
if r.Form.Get("lgtoken") == "" {
fmt.Fprintln(w, firstLogin)
} else {
fmt.Fprintln(w, failedLogin)
}
}))
defer ts.Close()
client, err := New(ts.URL, "TESTING")
if err != nil {
t.Fatalf("Error creating client: %s", err)
}
client.Domain = "asdf"
err = client.Login("asdf", "asdf")
if err == nil {
t.Error("Client logged in successfully. (BUT THIS IS BAD!)")
} else {
t.Logf("Client failed to login: %s (BUT THIS IS GOOD!)", err)
}
}

func TestLoginNoPW(t *testing.T) {
test := BuildUp(failedLogin, t)
defer test.TearDown()
err := test.client.Login("", "")
if err != nil {
t.Log("Client refused to login with password.")
} else {
t.Error("Client did not a return an error with no password set")
}
}

func TestLoginFailed(t *testing.T) {
test := BuildUp(failedLogin, t)
defer test.TearDown()
err := test.client.Login("asdf", "JKLa")
if err != nil {
t.Logf("Failed to log in: %s", err.Error())
} else {
t.Error("Client logged in successfully to incorrect response")
}
}

func TestPostForm(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
panic(err)
}

	if r.Header.Get("user-agent") != "mediawiki (Golang) https://github.com/sadbox/mediawiki TESTING" {
		fmt.Fprintln(w, "USERAGENT")
	} else {
		fmt.Fprintln(w, r.Form.Get("KEY"))
	}
}))
defer ts.Close()
client, err := New(ts.URL, "TESTING")
if err != nil {
	t.Fatalf("Error creating client: %s", err.Error())
}
value, err := client.postForm(url.Values{"KEY": []string{"VALUE"}})
if err != nil {
	t.Errorf("Error posting data: %s", err.Error())
}
returnValue := strings.TrimSpace(string(value))
if returnValue == "VALUE" {
	t.Log("Successfully posted to web service.")
} else if returnValue == "USERAGENT" {
	t.Error("Wrong useragent used!")
} else {
	t.Error("Did not retrieve right value from web service")
}

}

func TestAPI(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
panic(err)
}
if r.Form.Get("KEY") != "VALUE" || r.Form.Get("OTHER KEY") != "OTHER VALUE" || r.Form.Get("format") != "json" {
fmt.Fprintln(w, {"status":"FAIL"})
} else {
fmt.Fprintln(w, {"status":"PASS"})
}
}))
defer ts.Close()
client, err := New(ts.URL, "TESTING")
if err != nil {
t.Fatalf("Error creating client: %s", err.Error())
}
body, err := client.API(map[string]string{"KEY": "VALUE", "OTHER KEY": "OTHER VALUE"})
if err != nil {
t.Fatalf("API() returned a non-nil error: %s", err.Error())
}
if strings.TrimSpace(string(body)) == {"status":"PASS"} {
t.Log("Successfully posted all information via API() call")
} else {
t.Error("Did not get PASS back from test server when posting via API()")
}
}

func TestRead(t *testing.T) {
test := BuildUp(readPage, t)
defer test.TearDown()
page, err := test.client.Read("TESTING PAGE")
if err != nil {
t.Fatalf("Unable to read page: %s", err)
}
if page.Revisions[0].Body != "FULL PAGE TEXT" {
t.Error("Page content not correct")
}
}

func TestDownload(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
panic(err)
}
if r.Method == "POST" {
fmt.Fprintln(w, fmt.Sprintf(fileURL, r.Form.Get("titles")))
} else if r.Method == "GET" {
fmt.Fprintf(w, THINGS)
}
}))
defer ts.Close()
client, err := New(ts.URL, "TESTING")
if err != nil {
t.Fatalf("Error creating client: %s", err.Error())
}
file, err := client.Download(ts.URL)
if err != nil {
t.Fatalf("Error downloading file: %s", err.Error())
}
defer file.Close()
returned, err := ioutil.ReadAll(file)
if err != nil {
t.Fatalf("Error reading downloaded file: %s", err.Error())
}
if string(returned) != "THINGS" {
t.Fatalf("Returned file was not correct")
}
}

func TestDownloadNoFiles(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
panic(err)
}
if r.Method == "POST" {
fmt.Fprintln(w, fileURLFailed)
} else if r.Method == "GET" {
fmt.Fprintf(w, THINGS)
}
}))
defer ts.Close()
client, err := New(ts.URL, "TESTING")
if err != nil {
t.Fatalf("Error creating client: %s", err)
}
_, err = client.Download(ts.URL)
if err != nil {
t.Log("Successfully returned error when no files were found", err)
} else {
t.Fatal("No error return when no files were found", err)
}
}

func TestUpload(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
err := r.ParseMultipartForm(int64(10000))
if err != nil {
panic(err)
}
formValues := r.MultipartForm.Value
referenceValues := map[string]string{
"action": "upload",
"format": "json",
"filename": "test.txt",
"token": "ASDFASDF",
}
NextKey:
for key, value := range formValues {
for innerKey, innerValue := range referenceValues {
if key == innerKey && value[0] == innerValue {
continue NextKey
}
}
fmt.Fprintln(w, fmt.Sprintf({"upload":{"result":"Value did not match: %s"}}, key))
return
}
uploadedFile, err := r.MultipartForm.File["file"][0].Open()
if err != nil {
fmt.Fprintln(w, {"upload":{"result":"Error opening uploaded file"}})
return
}
defer uploadedFile.Close()
contents, err := ioutil.ReadAll(uploadedFile)
if err != nil {
panic(err)
}
if string(contents) != "THIS IS A TEST" {
fmt.Fprintln(w, {"upload":{"result":"File contents are not valid"}})
return
}
fmt.Fprintln(w, {"upload":{"result":"Success"}})
}))
defer ts.Close()
client, err := New(ts.URL, "TESTING")
if err != nil {
t.Fatalf("Error creating client: %s", err.Error())
}
client.edittoken = "ASDFASDF"
err = client.Upload("test.txt", strings.NewReader("THIS IS A TEST"))
if err != nil {
t.Fatalf("Error trying to upload file: %s", err)
}
}

func TestUploadAutoToken(t *testing.T) {
test := BuildUp(editTokenReponse, t)
defer test.TearDown()
test.client.Upload("stuff", strings.NewReader("stuff"))
if test.client.edittoken == "" {
t.Fatalf("Edit token did not get set properly")
}
}

func TestUploadFailResponse(t *testing.T) {
test := BuildUp({"upload":{"result":"THIS SHOULD BE AN ERROR"}}, t)
defer test.TearDown()
test.client.edittoken = "ASDF"
err := test.client.Upload("stuff", strings.NewReader("stuff"))
if err == nil {
t.Fatal("Did not generate error when upload returned failed result", err)
} else {
t.Log("Successfully generated error from failed upload", err)
}
}

func TestMWError(t *testing.T) {
test := BuildUp(mwerror, t)
defer test.TearDown()
_, err := test.client.Read("DOESN'T MATTER")
if err != nil {
t.Log("Properly recieved error:", err)
} else {
t.Fatalf("Mediawiki error did not get translated to a go error")
}
}

func TestEditAutoToken(t *testing.T) {
test := BuildUp(editTokenReponse, t)
defer test.TearDown()
test.client.Edit(map[string]string{"thing": "OTHER THING"})
if test.client.edittoken == "" {
t.Fatalf("Edit token did not get set properly")
}
}

func TestEditSuccess(t *testing.T) {
test := BuildUp(editsuccess, t)
defer test.TearDown()
test.client.edittoken = "asdf"
err := test.client.Edit(map[string]string{"title": "somepage"})
if err != nil {
t.Fatal("Did not get non-error response back", err)
}
}

func TestEditFail(t *testing.T) {
test := BuildUp(editfailure, t)
defer test.TearDown()
err := test.client.Edit(map[string]string{"title": "somepage"})
if err == nil {
t.Fatal("Did not get non-error response back", err)
}
}

func TestBasicAuth(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Header.Get("Authorization") != "Basic Zm9vOmJhcg==" {
t.Fatalf("Did not recieve correct basic auth header: %s", r.Header.Get(r.Header.Get("Authorization")))
}
}))
defer ts.Close()
client, err := New(ts.URL, "TESTING")
if err != nil {
t.Fatalf("Error creating client: %s", err.Error())
}

client.UseBasicAuth = true
client.BasicAuthUser = "foo"
client.BasicAuthPass = "bar"

t.Log(client)

_, err = client.API()
if err != nil {
	t.Fatalf("API() returned a non-nil error: %s", err.Error())
}

}

@bpavo
Copy link
Author

bpavo commented Sep 30, 2023

José de San Pedro en películes de

@jdneo
Copy link
Member

jdneo commented Oct 7, 2023

Please provide clear description about your problem

@jdneo jdneo closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants