From 77ce544c43ad400d26508d18e28b3aabb8c95107 Mon Sep 17 00:00:00 2001
From: Matthew Fisher <40250218+MicroFish91@users.noreply.github.com>
Date: Fri, 20 Dec 2024 15:55:19 -0800
Subject: [PATCH] Improve output and activity logs for `deployContainerApp`
 (#806)

---
 .../deployContainerApp/deployContainerApp.ts  | 23 +++++++++-
 .../image/deployImageApi/deployImage.ts       | 19 ++------
 .../imageSource/ContainerAppUpdateStep.ts     | 16 ++++++-
 .../image/imageSource/EnvFileListStep.ts      | 19 ++++++--
 .../image/imageSource/ImageSourceContext.ts   |  1 +
 .../image/imageSource/ImageSourceListStep.ts  | 24 ++++++++--
 .../ContainerRegistryImageConfigureStep.ts    | 46 +++++++++++++------
 .../RegistryImageInputStep.ts                 |  2 +-
 .../containerRegistry/acr/AcrListStep.ts      |  2 +-
 .../acr/AcrRepositoriesListStep.ts            |  2 +-
 .../DockerHubContainerRepositoryListStep.ts   |  2 +-
 .../dockerHub/DockerHubNamespaceInputStep.ts  |  2 +-
 .../getLatestContainerImage.ts                |  5 +-
 src/commands/ingress/IngressPromptStep.ts     | 14 +-----
 .../disableIngress/DisableIngressStep.ts      | 28 ++++++++++-
 .../enableIngress/EnableIngressStep.ts        | 20 +++++---
 ...stryCredentialsAddConfigurationListStep.ts | 13 ++++--
 src/tree/ContainerAppItem.ts                  |  2 +
 18 files changed, 171 insertions(+), 69 deletions(-)

diff --git a/src/commands/deployContainerApp/deployContainerApp.ts b/src/commands/deployContainerApp/deployContainerApp.ts
index 307bd3467..a6acaaf1a 100644
--- a/src/commands/deployContainerApp/deployContainerApp.ts
+++ b/src/commands/deployContainerApp/deployContainerApp.ts
@@ -5,8 +5,9 @@
 
 import { type ResourceGroup } from "@azure/arm-resources";
 import { LocationListStep, ResourceGroupListStep } from "@microsoft/vscode-azext-azureutils";
-import { AzureWizard, createSubscriptionContext, nonNullProp, nonNullValue, type IActionContext, type ISubscriptionActionContext, type ISubscriptionContext } from "@microsoft/vscode-azext-utils";
+import { activityInfoIcon, activitySuccessContext, AzureWizard, createSubscriptionContext, createUniversallyUniqueContextValue, GenericTreeItem, nonNullProp, nonNullValue, type IActionContext, type ISubscriptionActionContext, type ISubscriptionContext } from "@microsoft/vscode-azext-utils";
 import { ImageSource } from "../../constants";
+import { ext } from "../../extensionVariables";
 import { type ContainerAppItem } from "../../tree/ContainerAppItem";
 import { createActivityContext } from "../../utils/activityUtils";
 import { isAzdExtensionInstalled } from "../../utils/azdUtils";
@@ -50,6 +51,26 @@ export async function deployContainerApp(context: IActionContext, node?: Contain
         localize('containerAppResourceGroup', 'Expected to find the container app\'s resource group.'),
     );
 
+    // Log resource group
+    wizardContext.activityChildren?.push(
+        new GenericTreeItem(undefined, {
+            contextValue: createUniversallyUniqueContextValue(['useExistingResourceGroupInfoItem', activitySuccessContext]),
+            label: localize('useResourceGroup', 'Using resource group "{0}"', wizardContext.resourceGroup.name),
+            iconPath: activityInfoIcon
+        })
+    );
+    ext.outputChannel.appendLog(localize('usingResourceGroup', 'Using resource group "{0}".', wizardContext.resourceGroup.name));
+
+    // Log container app
+    wizardContext.activityChildren?.push(
+        new GenericTreeItem(undefined, {
+            contextValue: createUniversallyUniqueContextValue(['useExistingContainerAppInfoItem', activitySuccessContext]),
+            label: localize('useContainerApp', 'Using container app "{0}"', wizardContext.containerApp?.name),
+            iconPath: activityInfoIcon
+        })
+    );
+    ext.outputChannel.appendLog(localize('usingContainerApp', 'Using container app "{0}".', wizardContext.containerApp?.name));
+
     await LocationListStep.setLocation(wizardContext, item.containerApp.location);
 
     const wizard: AzureWizard<ContainerAppDeployContext> = new AzureWizard(wizardContext, {
diff --git a/src/commands/image/deployImageApi/deployImage.ts b/src/commands/image/deployImageApi/deployImage.ts
index 35b138483..ceb03288f 100644
--- a/src/commands/image/deployImageApi/deployImage.ts
+++ b/src/commands/image/deployImageApi/deployImage.ts
@@ -3,16 +3,14 @@
 *  Licensed under the MIT License. See License.md in the project root for license information.
 *--------------------------------------------------------------------------------------------*/
 
-import { AzureWizard, createSubscriptionContext, type AzureWizardPromptStep, type IActionContext, type ISubscriptionContext } from "@microsoft/vscode-azext-utils";
+import { AzureWizard, createSubscriptionContext, type IActionContext, type ISubscriptionContext } from "@microsoft/vscode-azext-utils";
 import { type ContainerAppItem } from "../../../tree/ContainerAppItem";
 import { createActivityContext } from "../../../utils/activityUtils";
 import { getManagedEnvironmentFromContainerApp } from "../../../utils/getResourceUtils";
 import { getVerifyProvidersStep } from "../../../utils/getVerifyProvidersStep";
-import { getImageNameWithoutTag } from "../../../utils/imageNameUtils";
 import { localize } from "../../../utils/localize";
 import { ContainerAppOverwriteConfirmStep } from "../../ContainerAppOverwriteConfirmStep";
 import { showContainerAppNotification } from "../../createContainerApp/showContainerAppNotification";
-import { IngressPromptStep } from "../../ingress/IngressPromptStep";
 import { ContainerAppUpdateStep } from "../imageSource/ContainerAppUpdateStep";
 import { ImageSourceListStep } from "../imageSource/ImageSourceListStep";
 import { type ContainerRegistryImageSourceContext } from "../imageSource/containerRegistry/ContainerRegistryImageSourceContext";
@@ -33,19 +31,12 @@ export async function deployImage(context: IActionContext & Partial<ContainerReg
 
     wizardContext.telemetry.properties.revisionMode = containerApp.revisionsMode;
 
-    const promptSteps: AzureWizardPromptStep<DeployImageApiContext>[] = [
-        new ImageSourceListStep(),
-    ];
-
-    // If more than the image tag changed, prompt for ingress again
-    if (getImageNameWithoutTag(wizardContext.containerApp?.template?.containers?.[0].image ?? '') !== getImageNameWithoutTag(wizardContext.image ?? '')) {
-        promptSteps.push(new IngressPromptStep());
-    }
-    promptSteps.push(new ContainerAppOverwriteConfirmStep());
-
     const wizard: AzureWizard<DeployImageApiContext> = new AzureWizard(wizardContext, {
         title: localize('deploy', 'Deploy image to container app "{0}"', containerApp.name),
-        promptSteps,
+        promptSteps: [
+            new ImageSourceListStep(),
+            new ContainerAppOverwriteConfirmStep(),
+        ],
         executeSteps: [
             getVerifyProvidersStep<DeployImageApiContext>(),
             new ContainerAppUpdateStep(),
diff --git a/src/commands/image/imageSource/ContainerAppUpdateStep.ts b/src/commands/image/imageSource/ContainerAppUpdateStep.ts
index 365f14e7a..274da923a 100644
--- a/src/commands/image/imageSource/ContainerAppUpdateStep.ts
+++ b/src/commands/image/imageSource/ContainerAppUpdateStep.ts
@@ -4,14 +4,15 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { type Ingress } from "@azure/arm-appcontainers";
-import { AzureWizardExecuteStep, GenericParentTreeItem, GenericTreeItem, activityFailContext, activityFailIcon, activitySuccessContext, activitySuccessIcon, createUniversallyUniqueContextValue, nonNullProp, type ExecuteActivityOutput } from "@microsoft/vscode-azext-utils";
+import { activityFailContext, activityFailIcon, activitySuccessContext, activitySuccessIcon, AzureWizardExecuteStep, createUniversallyUniqueContextValue, GenericParentTreeItem, GenericTreeItem, nonNullProp, type ExecuteActivityOutput } from "@microsoft/vscode-azext-utils";
 import * as retry from "p-retry";
 import { type Progress } from "vscode";
 import { ext } from "../../../extensionVariables";
 import { getContainerEnvelopeWithSecrets, type ContainerAppModel } from "../../../tree/ContainerAppItem";
 import { localize } from "../../../utils/localize";
 import { type IngressContext } from "../../ingress/IngressContext";
-import { enabledIngressDefaults } from "../../ingress/enableIngress/EnableIngressStep";
+import { DisableIngressStep } from "../../ingress/disableIngress/DisableIngressStep";
+import { enabledIngressDefaults, EnableIngressStep } from "../../ingress/enableIngress/EnableIngressStep";
 import { RegistryCredentialType } from "../../registryCredentials/RegistryCredentialsAddConfigurationListStep";
 import { updateContainerApp } from "../../updateContainerApp";
 import { type ImageSourceContext } from "./ImageSourceContext";
@@ -41,6 +42,17 @@ export class ContainerAppUpdateStep<T extends ImageSourceContext & IngressContex
             ingress = containerAppEnvelope.configuration.ingress;
         }
 
+        // Display ingress log outputs
+        if (ingress) {
+            const { item, message } = EnableIngressStep.createSuccessOutput({ ...context, enableExternal: ingress.external, targetPort: ingress.targetPort });
+            item && context.activityChildren?.push(item);
+            message && ext.outputChannel.appendLog(message);
+        } else {
+            const { item, message } = DisableIngressStep.createSuccessOutput({ ...context, enableIngress: false });
+            item && context.activityChildren?.push(item);
+            message && ext.outputChannel.appendLog(message);
+        }
+
         containerAppEnvelope.configuration.ingress = ingress;
         containerAppEnvelope.configuration.secrets = context.secrets;
         containerAppEnvelope.configuration.registries = context.registryCredentials;
diff --git a/src/commands/image/imageSource/EnvFileListStep.ts b/src/commands/image/imageSource/EnvFileListStep.ts
index 95f2ac476..76f0f9129 100644
--- a/src/commands/image/imageSource/EnvFileListStep.ts
+++ b/src/commands/image/imageSource/EnvFileListStep.ts
@@ -121,18 +121,27 @@ export class EnvFileListStep<T extends EnvFileListContext> extends AzureWizardPr
 
             const logMessage: string = localize('skippedEnvVarsMessage',
                 'Skipped environment variable configuration for the container app' +
-                (setEnvironmentVariableOption === SetEnvironmentVariableOption.NoDotEnv ? ' because no .env files were detected. ' : '. ')
+                (setEnvironmentVariableOption === SetEnvironmentVariableOption.NoDotEnv ? ' because no .env files were detected.' : '.')
             );
             ext.outputChannel.appendLog(logMessage);
-        } else {
+        } else if (setEnvironmentVariableOption === SetEnvironmentVariableOption.ProvideFile) {
             context.activityChildren?.push(
                 new GenericTreeItem(undefined, {
-                    contextValue: createUniversallyUniqueContextValue(['envFileListStepSuccessItem', setEnvironmentVariableOption, activitySuccessContext]),
-                    label: localize('saveEnvVarsLabel', 'Save environment variable configuration'),
+                    contextValue: createUniversallyUniqueContextValue(['environmentVariablesListStepSuccessItem', activitySuccessContext]),
+                    label: localize('saveEnvVarsFileLabel', 'Save environment variables using provided .env file'),
+                    iconPath: activitySuccessIcon
+                })
+            );
+            ext.outputChannel.appendLog(localize('savedEnvVarsFileMessage', 'Saved environment variables using provided .env file "{0}".', context.envPath));
+        } else if (setEnvironmentVariableOption === SetEnvironmentVariableOption.UseExisting) {
+            context.activityChildren?.push(
+                new GenericTreeItem(undefined, {
+                    contextValue: createUniversallyUniqueContextValue(['environmentVariablesListStepSuccessItem', activitySuccessContext]),
+                    label: localize('useExistingEnvVarsLabel', 'Use existing environment variable configuration'),
                     iconPath: activitySuccessIcon
                 })
             );
-            ext.outputChannel.appendLog(localize('savedEnvVarsMessage', 'Saved environment variable configuration.'));
+            ext.outputChannel.appendLog(localize('useExistingEnvVarsMessage', 'Used existing environment variable configuration.'));
         }
     }
 }
diff --git a/src/commands/image/imageSource/ImageSourceContext.ts b/src/commands/image/imageSource/ImageSourceContext.ts
index eae8d7e00..8af0e2967 100644
--- a/src/commands/image/imageSource/ImageSourceContext.ts
+++ b/src/commands/image/imageSource/ImageSourceContext.ts
@@ -16,6 +16,7 @@ export interface ImageSourceBaseContext extends RegistryCredentialsContext, ICon
     imageSource?: ImageSource;
     showQuickStartImage?: boolean;
 
+    containersIdx?: number;
     image?: string;
 
     envPath?: string;
diff --git a/src/commands/image/imageSource/ImageSourceListStep.ts b/src/commands/image/imageSource/ImageSourceListStep.ts
index 70f2b2dd7..8f75d2173 100644
--- a/src/commands/image/imageSource/ImageSourceListStep.ts
+++ b/src/commands/image/imageSource/ImageSourceListStep.ts
@@ -77,13 +77,29 @@ export class ImageSourceListStep extends AzureWizardPromptStep<ImageSourceContex
                 context.telemetry.properties.imageSource = ImageSource.QuickstartImage;
                 break;
             case ImageSource.ContainerRegistry:
-                promptSteps.push(new ContainerRegistryListStep(), new RegistryCredentialsAddConfigurationListStep());
-                executeSteps.push(new ContainerRegistryImageConfigureStep());
+                promptSteps.push(
+                    new ContainerRegistryListStep(),
+                    new RegistryCredentialsAddConfigurationListStep(),
+                    new ContainerRegistryImageConfigureStep(),
+                );
                 context.telemetry.properties.imageSource = ImageSource.ContainerRegistry;
                 break;
             case ImageSource.RemoteAcrBuild:
-                promptSteps.push(new RootFolderStep(), new DockerfileItemStep(), new SourcePathStep(), new AcrListStep(), new RegistryCredentialsAddConfigurationListStep(), new ImageNameStep(), new OSPickStep());
-                executeSteps.push(new TarFileStep(), new UploadSourceCodeStep(), new RunStep(), new BuildImageStep(), new ContainerRegistryImageConfigureStep());
+                promptSteps.push(
+                    new RootFolderStep(),
+                    new DockerfileItemStep(),
+                    new SourcePathStep(),
+                    new AcrListStep(),
+                    new RegistryCredentialsAddConfigurationListStep(),
+                    new ImageNameStep(),
+                    new OSPickStep(),
+                );
+                executeSteps.push(
+                    new TarFileStep(),
+                    new UploadSourceCodeStep(),
+                    new RunStep(),
+                    new BuildImageStep(),
+                );
                 context.telemetry.properties.imageSource = ImageSource.RemoteAcrBuild;
                 break;
             default:
diff --git a/src/commands/image/imageSource/containerRegistry/ContainerRegistryImageConfigureStep.ts b/src/commands/image/imageSource/containerRegistry/ContainerRegistryImageConfigureStep.ts
index 622d33526..0adfbd410 100644
--- a/src/commands/image/imageSource/containerRegistry/ContainerRegistryImageConfigureStep.ts
+++ b/src/commands/image/imageSource/containerRegistry/ContainerRegistryImageConfigureStep.ts
@@ -3,28 +3,48 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { parseImageName } from "../../../../utils/imageNameUtils";
+import { activitySuccessContext, activitySuccessIcon, AzureWizardPromptStep, createUniversallyUniqueContextValue, GenericTreeItem, type IWizardOptions } from "@microsoft/vscode-azext-utils";
+import { ext } from "../../../../extensionVariables";
+import { getImageNameWithoutTag, parseImageName } from "../../../../utils/imageNameUtils";
 import { localize } from "../../../../utils/localize";
-import { AzureWizardActivityOutputExecuteStep } from "../../../AzureWizardActivityOutputExecuteStep";
+import { IngressPromptStep } from "../../../ingress/IngressPromptStep";
 import { type ContainerRegistryImageSourceContext } from "./ContainerRegistryImageSourceContext";
 import { getLoginServer } from "./getLoginServer";
 
-export class ContainerRegistryImageConfigureStep<T extends ContainerRegistryImageSourceContext> extends AzureWizardActivityOutputExecuteStep<T> {
-    public priority: number = 570;
-    public stepName: string = 'containerRegistryImageConfigureStep';
-    protected getSuccessString = (context: T) => localize('successOutput', 'Successfully set container image to "{0}".', context.image);
-    protected getFailString = (context: T) => localize('failOutput', 'Failed to set container image to "{0}".', context.image);
-    protected getTreeItemLabel = (context: T) => localize('treeItemLabel', 'Set container image to "{0}"', context.image);
-
-    public async execute(context: T): Promise<void> {
-        context.image = `${getLoginServer(context)}/${context.repositoryName}:${context.tag}`;
+export class ContainerRegistryImageConfigureStep<T extends ContainerRegistryImageSourceContext> extends AzureWizardPromptStep<T> {
+    public async configureBeforePrompt(context: T): Promise<void> {
+        context.image ||= `${getLoginServer(context)}/${context.repositoryName}:${context.tag}`;
 
         const { registryName, registryDomain } = parseImageName(context.image);
         context.telemetry.properties.registryName = registryName;
         context.telemetry.properties.registryDomain = registryDomain ?? 'other';
+
+        // Output logs
+        context.activityChildren?.push(
+            new GenericTreeItem(undefined, {
+                contextValue: createUniversallyUniqueContextValue(['containerRegistryImageConfigureStepItem', activitySuccessContext]),
+                label: localize('configureTargetImageLabel', 'Configure target image "{0}"', context.image),
+                iconPath: activitySuccessIcon
+            })
+        );
+        ext.outputChannel.appendLog(localize('configureTargetImageMessage', 'Configured target image "{0}".', context.image));
+    }
+
+    public async prompt(): Promise<void> {
+        // Don't prompt, just need to use the subwizard
+    }
+
+    public shouldPrompt(): boolean {
+        return false;
     }
 
-    public shouldExecute(context: T): boolean {
-        return !context.image;
+    public async getSubWizard(context: T): Promise<IWizardOptions<T> | undefined> {
+        // If more than the image tag changed, prompt for ingress again
+        if (getImageNameWithoutTag(context.containerApp?.template?.containers?.[context.containersIdx ?? 0].image ?? '') !== getImageNameWithoutTag(context.image ?? '')) {
+            return {
+                promptSteps: [new IngressPromptStep()],
+            };
+        }
+        return undefined;
     }
 }
diff --git a/src/commands/image/imageSource/containerRegistry/RegistryImageInputStep.ts b/src/commands/image/imageSource/containerRegistry/RegistryImageInputStep.ts
index 8c5160954..7ef204139 100644
--- a/src/commands/image/imageSource/containerRegistry/RegistryImageInputStep.ts
+++ b/src/commands/image/imageSource/containerRegistry/RegistryImageInputStep.ts
@@ -18,7 +18,7 @@ export class RegistryImageInputStep extends AzureWizardPromptStep<ContainerRegis
         // Try to suggest an image name only when the user is deploying to a Container App
         let value: string | undefined;
         if (context.containerApp) {
-            const { registryDomain, imageNameReference } = parseImageName(getLatestContainerAppImage(context.containerApp));
+            const { registryDomain, imageNameReference } = parseImageName(getLatestContainerAppImage(context.containerApp, context.containersIdx ?? 0));
 
             // Only bother carrying over the suggestion if the old image was from a third party registry
             if (registryDomain !== acrDomain && imageNameReference !== quickStartImageName) {
diff --git a/src/commands/image/imageSource/containerRegistry/acr/AcrListStep.ts b/src/commands/image/imageSource/containerRegistry/acr/AcrListStep.ts
index b3ce632a0..5822d13d8 100644
--- a/src/commands/image/imageSource/containerRegistry/acr/AcrListStep.ts
+++ b/src/commands/image/imageSource/containerRegistry/acr/AcrListStep.ts
@@ -79,7 +79,7 @@ export class AcrListStep extends AzureWizardPromptStep<ContainerRegistryImageSou
         let suggestedRegistry: string | undefined;
         let srExists: boolean = false;
         if (context.containerApp) {
-            const { registryDomain, registryName, imageNameReference } = parseImageName(getLatestContainerAppImage(context.containerApp));
+            const { registryDomain, registryName, imageNameReference } = parseImageName(getLatestContainerAppImage(context.containerApp, context.containersIdx ?? 0));
 
             // If the image is not the default quickstart image, then we can try to suggest a registry based on the latest Container App image
             if (
diff --git a/src/commands/image/imageSource/containerRegistry/acr/AcrRepositoriesListStep.ts b/src/commands/image/imageSource/containerRegistry/acr/AcrRepositoriesListStep.ts
index 2fa74ff24..ca371572a 100644
--- a/src/commands/image/imageSource/containerRegistry/acr/AcrRepositoriesListStep.ts
+++ b/src/commands/image/imageSource/containerRegistry/acr/AcrRepositoriesListStep.ts
@@ -22,7 +22,7 @@ export class AcrRepositoriesListStep extends RegistryRepositoriesListStepBase {
         let suggestedRepository: string | undefined;
         let srExists: boolean = false;
         if (context.containerApp) {
-            const { registryDomain, registryName, repositoryName } = parseImageName(getLatestContainerAppImage(context.containerApp));
+            const { registryDomain, registryName, repositoryName } = parseImageName(getLatestContainerAppImage(context.containerApp, context.containersIdx ?? 0));
             if (
                 context.containerApp.revisionsMode === KnownActiveRevisionsMode.Single &&
                 registryDomain === acrDomain &&
diff --git a/src/commands/image/imageSource/containerRegistry/dockerHub/DockerHubContainerRepositoryListStep.ts b/src/commands/image/imageSource/containerRegistry/dockerHub/DockerHubContainerRepositoryListStep.ts
index 2bcac202c..748f13042 100644
--- a/src/commands/image/imageSource/containerRegistry/dockerHub/DockerHubContainerRepositoryListStep.ts
+++ b/src/commands/image/imageSource/containerRegistry/dockerHub/DockerHubContainerRepositoryListStep.ts
@@ -24,7 +24,7 @@ export class DockerHubContainerRepositoryListStep extends RegistryRepositoriesLi
         let suggestedRepository: string | undefined;
         let srExists: boolean = false;
         if (context.containerApp) {
-            const { registryDomain, namespace, repositoryName } = parseImageName(getLatestContainerAppImage(context.containerApp));
+            const { registryDomain, namespace, repositoryName } = parseImageName(getLatestContainerAppImage(context.containerApp, context.containersIdx ?? 0));
             if (
                 context.containerApp.revisionsMode === KnownActiveRevisionsMode.Single &&
                 registryDomain === dockerHubDomain &&
diff --git a/src/commands/image/imageSource/containerRegistry/dockerHub/DockerHubNamespaceInputStep.ts b/src/commands/image/imageSource/containerRegistry/dockerHub/DockerHubNamespaceInputStep.ts
index 8d7ee572d..d1b4bbf75 100644
--- a/src/commands/image/imageSource/containerRegistry/dockerHub/DockerHubNamespaceInputStep.ts
+++ b/src/commands/image/imageSource/containerRegistry/dockerHub/DockerHubNamespaceInputStep.ts
@@ -43,7 +43,7 @@ export class DockerHubNamespaceInputStep extends AzureWizardPromptStep<Container
     private getSuggestedNamespace(context: ContainerRegistryImageSourceContext): string {
         let suggestedNamespace: string | undefined;
         if (context.containerApp) {
-            const { registryDomain, namespace } = parseImageName(getLatestContainerAppImage(context.containerApp));
+            const { registryDomain, namespace } = parseImageName(getLatestContainerAppImage(context.containerApp, context.containersIdx ?? 0));
             if (context.containerApp.revisionsMode === KnownActiveRevisionsMode.Single && registryDomain === dockerHubDomain) {
                 suggestedNamespace = namespace;
             }
diff --git a/src/commands/image/imageSource/containerRegistry/getLatestContainerImage.ts b/src/commands/image/imageSource/containerRegistry/getLatestContainerImage.ts
index 2944b149e..de5a0f6c6 100644
--- a/src/commands/image/imageSource/containerRegistry/getLatestContainerImage.ts
+++ b/src/commands/image/imageSource/containerRegistry/getLatestContainerImage.ts
@@ -5,7 +5,6 @@
 
 import { type ContainerApp } from "@azure/arm-appcontainers";
 
-export function getLatestContainerAppImage(containerApp: ContainerApp): string | undefined {
-    // We are currently only supporting one active container image per app
-    return containerApp.template?.containers?.[0]?.image;
+export function getLatestContainerAppImage(containerApp: ContainerApp, containersIdx: number): string | undefined {
+    return containerApp.template?.containers?.[containersIdx]?.image;
 }
diff --git a/src/commands/ingress/IngressPromptStep.ts b/src/commands/ingress/IngressPromptStep.ts
index 15daa5c15..ac399680d 100644
--- a/src/commands/ingress/IngressPromptStep.ts
+++ b/src/commands/ingress/IngressPromptStep.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { AzureWizardPromptStep, GenericTreeItem, activitySuccessContext, activitySuccessIcon, createUniversallyUniqueContextValue, type AzureWizardExecuteStep, type IWizardOptions } from "@microsoft/vscode-azext-utils";
+import { AzureWizardPromptStep, type AzureWizardExecuteStep, type IWizardOptions } from "@microsoft/vscode-azext-utils";
 import { ext } from "../../extensionVariables";
 import { localize } from "../../utils/localize";
 import { type IngressContext } from "./IngressContext";
@@ -61,7 +61,7 @@ export async function tryConfigureIngressUsingDockerfile(context: IngressContext
 
     if (context.dockerfileExposePorts) {
         context.enableIngress = true;
-        context.enableExternal = true;
+        context.enableExternal = context.containerApp?.configuration?.ingress?.external ?? true;
         context.targetPort = getDefaultPort(context);
     } else {
         context.enableIngress = false;
@@ -74,16 +74,6 @@ export async function tryConfigureIngressUsingDockerfile(context: IngressContext
         return;
     }
 
-    context.activityChildren?.push(
-        new GenericTreeItem(undefined, {
-            contextValue: createUniversallyUniqueContextValue(['ingressPromptStepSuccessItem', activitySuccessContext]),
-            label: context.enableIngress ?
-                localize('ingressEnableLabel', 'Enable ingress on port {0} (from Dockerfile configuration)', context.targetPort) :
-                localize('ingressDisableLabel', 'Disable ingress (from Dockerfile configuration)'),
-            iconPath: activitySuccessIcon
-        })
-    );
-
     ext.outputChannel.appendLog(context.enableIngress ?
         localize('ingressEnabledLabel', 'Detected ingress on port {0} using Dockerfile configuration.', context.targetPort) :
         localize('ingressDisabledLabel', 'Detected no ingress using Dockerfile configuration.')
diff --git a/src/commands/ingress/disableIngress/DisableIngressStep.ts b/src/commands/ingress/disableIngress/DisableIngressStep.ts
index 1012e8b73..4971bf042 100644
--- a/src/commands/ingress/disableIngress/DisableIngressStep.ts
+++ b/src/commands/ingress/disableIngress/DisableIngressStep.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { nonNullProp } from "@microsoft/vscode-azext-utils";
+import { activitySuccessContext, activitySuccessIcon, createUniversallyUniqueContextValue, GenericTreeItem, nonNullProp, type ExecuteActivityOutput } from "@microsoft/vscode-azext-utils";
 import { type Progress } from "vscode";
 import { localize } from "../../../utils/localize";
 import { type IngressBaseContext } from "../IngressContext";
@@ -25,4 +25,30 @@ export class DisableIngressStep extends IngressUpdateStepBase<IngressBaseContext
     public shouldExecute(context: IngressBaseContext): boolean {
         return context.enableIngress === false && isIngressEnabled(context);
     }
+
+    public static createSuccessOutput(context: IngressBaseContext): ExecuteActivityOutput {
+        return {
+            item: new GenericTreeItem(undefined, {
+                contextValue: createUniversallyUniqueContextValue(['disableIngressStepSuccessItem', activitySuccessContext]),
+                label: localize('disableIngressLabel', 'Disable ingress for container app "{0}"', context.containerApp?.name),
+                iconPath: activitySuccessIcon
+            }),
+            message: localize('disableSuccessMessage', 'Disabled ingress for container app "{0}".', context.containerApp?.name)
+        };
+    }
+
+    public createSuccessOutput(context: IngressBaseContext): ExecuteActivityOutput {
+        return DisableIngressStep.createSuccessOutput(context);
+    }
+
+    public createFailOutput(context: IngressBaseContext): ExecuteActivityOutput {
+        return {
+            item: new GenericTreeItem(undefined, {
+                contextValue: createUniversallyUniqueContextValue(['disableIngressStepFailItem', activitySuccessContext]),
+                label: localize('disableIngressLabel', 'Disable ingress for container app "{0}"', context.containerApp?.name),
+                iconPath: activitySuccessIcon
+            }),
+            message: localize('disableFailMessage', 'Failed to disable ingress for container app "{0}".', context.containerApp?.name)
+        };
+    }
 }
diff --git a/src/commands/ingress/enableIngress/EnableIngressStep.ts b/src/commands/ingress/enableIngress/EnableIngressStep.ts
index fc81d97c1..5673f4b9b 100644
--- a/src/commands/ingress/enableIngress/EnableIngressStep.ts
+++ b/src/commands/ingress/enableIngress/EnableIngressStep.ts
@@ -39,28 +39,36 @@ export class EnableIngressStep extends AzureWizardExecuteStep<IngressBaseContext
     }
 
     public shouldExecute(context: IngressBaseContext): boolean {
-        return context.enableIngress === true && context.targetPort !== context.containerApp?.configuration?.ingress?.targetPort;
+        const hasNewVisiblity: boolean = context.enableExternal !== undefined && context.enableExternal !== context.containerApp?.configuration?.ingress?.external;
+        const hasNewTargetPort: boolean = !!context.targetPort && context.targetPort !== context.containerApp?.configuration?.ingress?.targetPort;
+        return context.enableIngress === true && hasNewVisiblity || hasNewTargetPort;
     }
 
-    public createSuccessOutput(context: IngressBaseContext): ExecuteActivityOutput {
+    public static createSuccessOutput(context: IngressBaseContext): ExecuteActivityOutput {
+        const visibility: string = context.enableExternal ? localize('external', 'external') : localize('internal', 'internal');
         return {
             item: new GenericTreeItem(undefined, {
                 contextValue: createUniversallyUniqueContextValue(['enableIngressStepSuccessItem', activitySuccessContext]),
-                label: localize('enableIngressLabel', 'Enable ingress on port {0} for container app "{1}"', context.targetPort, context.containerApp?.name),
+                label: localize('enableIngressLabel', 'Enable {0} ingress on port {1}', visibility, context.targetPort),
                 iconPath: activitySuccessIcon
             }),
-            message: localize('enableCompleted', 'Enabled ingress on port {0} for container app "{1}".', context.targetPort, context.containerApp?.name)
+            message: localize('enableCompleted', 'Enabled {0} ingress on port {1}.', visibility, context.targetPort)
         };
     }
 
+    public createSuccessOutput(context: IngressBaseContext): ExecuteActivityOutput {
+        return EnableIngressStep.createSuccessOutput(context);
+    }
+
     public createFailOutput(context: IngressBaseContext): ExecuteActivityOutput {
+        const visibility: string = context.enableExternal ? localize('external', 'external') : localize('internal', 'internal');
         return {
             item: new GenericParentTreeItem(undefined, {
                 contextValue: createUniversallyUniqueContextValue(['enableIngressStepFailItem', activityFailContext]),
-                label: localize('enableIngressLabel', 'Enable ingress on port {0} for container app "{1}"', context.targetPort, context.containerApp?.name),
+                label: localize('enableIngressLabel', 'Enable {0} ingress on port {1}', visibility, context.targetPort),
                 iconPath: activityFailIcon
             }),
-            message: localize('enableIngressFailed', 'Failed to enable ingress on port {0} for container app "{1}".', context.targetPort, context.containerApp?.name)
+            message: localize('enableIngressFailed', 'Failed to enable {0} ingress on port {1}.', visibility, context.targetPort)
         };
     }
 }
diff --git a/src/commands/registryCredentials/RegistryCredentialsAddConfigurationListStep.ts b/src/commands/registryCredentials/RegistryCredentialsAddConfigurationListStep.ts
index b2b93076f..4120832e3 100644
--- a/src/commands/registryCredentials/RegistryCredentialsAddConfigurationListStep.ts
+++ b/src/commands/registryCredentials/RegistryCredentialsAddConfigurationListStep.ts
@@ -3,8 +3,9 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { AzureWizardPromptStep, nonNullProp, type AzureWizardExecuteStep, type IAzureQuickPickItem, type IWizardOptions } from "@microsoft/vscode-azext-utils";
+import { activitySuccessContext, activitySuccessIcon, AzureWizardPromptStep, createUniversallyUniqueContextValue, GenericTreeItem, nonNullProp, type AzureWizardExecuteStep, type IAzureQuickPickItem, type IWizardOptions } from "@microsoft/vscode-azext-utils";
 import { acrDomain, type SupportedRegistries } from "../../constants";
+import { ext } from "../../extensionVariables";
 import { getRegistryDomainFromContext } from "../../utils/imageNameUtils";
 import { localize } from "../../utils/localize";
 import { AcrEnableAdminUserConfirmStep } from "./dockerLogin/AcrEnableAdminUserConfirmStep";
@@ -86,6 +87,14 @@ export class RegistryCredentialsAddConfigurationListStep extends AzureWizardProm
                 );
                 break;
             default:
+                context.activityChildren?.push(
+                    new GenericTreeItem(undefined, {
+                        contextValue: createUniversallyUniqueContextValue(['registryCredentialsAddConfigurationListStepVerifyItem', activitySuccessContext]),
+                        label: localize('verifyRegistryCredentials', 'Verify existing registry credential'),
+                        iconPath: activitySuccessIcon
+                    })
+                );
+                ext.outputChannel.appendLog(localize('verifiedRegistryCredentials', 'Verified existing registry credentials.'));
         }
 
         executeSteps.push(new RegistryCredentialsAndSecretsConfigurationStep());
@@ -96,8 +105,6 @@ export class RegistryCredentialsAddConfigurationListStep extends AzureWizardProm
         };
     }
 
-
-
     public async getPicks(context: RegistryCredentialsContext): Promise<IAzureQuickPickItem<RegistryCredentialType>[]> {
         const picks: IAzureQuickPickItem<RegistryCredentialType>[] = [];
         const registryDomain = getRegistryDomainFromContext(context);
diff --git a/src/tree/ContainerAppItem.ts b/src/tree/ContainerAppItem.ts
index 37c052e75..96b71da9d 100644
--- a/src/tree/ContainerAppItem.ts
+++ b/src/tree/ContainerAppItem.ts
@@ -212,6 +212,8 @@ export async function getContainerEnvelopeWithSecrets(context: IActionContext, s
     const concreteContainerAppEnvelope = <Required<ContainerApp>>containerAppEnvelope;
     const webClient: ContainerAppsAPIClient = await createContainerAppsAPIClient([context, createSubscriptionContext(subscription)]);
 
+    // Todo: If a container app fails to provision, this list command may error with code 400
+    // We need to determine the best way to break the user out of this state once they get locked into it
     concreteContainerAppEnvelope.configuration.secrets = ((await webClient.containerApps.listSecrets(containerApp.resourceGroup, containerApp.name)).value);
     concreteContainerAppEnvelope.configuration.registries ||= [];