Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date] Looks like current port implementation is broken #32765

Closed
kreuzerkrieg opened this issue Jul 26, 2023 · 4 comments · Fixed by #32772
Closed

[date] Looks like current port implementation is broken #32765

kreuzerkrieg opened this issue Jul 26, 2023 · 4 comments · Fixed by #32772
Labels
category:port-update The issue is with a library, which is requesting update new revision

Comments

@kreuzerkrieg
Copy link
Contributor

Library name

date

New version number

no new version

Other information that may be useful (release notes, etc...)

Looks like the port somehow misses this include, iso_week.h despite, as I understand, these lines should assure it will get to the target include directory

target_sources( date INTERFACE
     $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include/date/iso_week.h>
     $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include/date/julian.h>
 )

Please advise.

@kreuzerkrieg kreuzerkrieg added the category:port-update The issue is with a library, which is requesting update new revision label Jul 26, 2023
@kreuzerkrieg kreuzerkrieg changed the title [date] Looks like current port implementation somewhat is broken [date] Looks like current port implementation is broken Jul 26, 2023
@lconn-dev
Copy link

Hi there, please add any other relevant information, such as platform, target, build failure logs, error messages, etc. See CONTRIBUTING.md. Thanks!

@xiaozhuai
Copy link
Contributor

@kreuzerkrieg
This problem originates upstream.
I will try to fix it.

@xiaozhuai
Copy link
Contributor

@kreuzerkrieg
Please try #32772 to see if it works.

@kreuzerkrieg
Copy link
Contributor Author

@kreuzerkrieg Please try #32772 to see if it works.

looks ok

ll installed/x64-linux/include/date/
total 632
drwxrwxr-x  2 user user   4096 Jul 26 16:11 ./
drwxrwxr-x 29 user user   4096 Jul 26 16:11 ../
-rw-r--r--  2 user user 236099 Jul 26 16:11 date.h
-rw-r--r--  2 user user   1617 Apr 17  2021 ios.h
-rw-r--r--  2 user user  71119 Apr 17  2021 islamic.h
-rw-r--r--  2 user user  43034 Apr 17  2021 iso_week.h
-rw-r--r--  2 user user  71992 Apr 17  2021 julian.h
-rw-r--r--  2 user user  24012 Apr 17  2021 ptz.h
-rw-r--r--  2 user user  78738 Apr 17  2021 solar_hijri.h
-rw-r--r--  2 user user  84617 Apr 17  2021 tz.h
-rw-r--r--  2 user user  10690 Apr 17  2021 tz_private.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants