incorrect 'error: Unnecessary "# type: ignore" comment'

[akirakoyasu]

Note: if you are reporting a wrong signature of a function or a class in the standard library, then the typeshed tracker is better suited for this report: https://github.com/python/typeshed/issues.

Describe the bug
pyright 1.1.283 reports incorrect 'error: Unnecessary "# type: ignore" comment' in commented out code.

Enhancement of 1.1.283
Added support for # pyright: ignore and # type: ignore comments that are not at the start of a comment.
produces this bug?

To Reproduce
Check this snippet by pyright 1.1.283

# fileConfig(config.config_file_name)  # type: ignore

Expected behavior
"# type: ignore" comment in commented out code should be ignored.

[erictraut]

Yes, this is intended behavior. This is a side effect of a recent change. Previously, # pyright: ignore and # type: ignore were honored only when there were located at the beginning of a comment. They are now honored anywhere within a comment. That means the code in your sample is considered an unnecessary use of # type: ignore and will be flagged as such by the reportUnnecessaryTypeIgnoreComment diagnostic check. You would have seen the same behavior prior to 1.1.283 if you had used a # type: ignore by itself on a line.

[Jeremiah-England]

It would be nice if you could comment out a block of code without getting "information" warnings about reportUnnecessaryTypeIgnoreComment. Those warnings clutter up the output. But it doesn't make sense to remove from from the commented out block because you will need to add them back when you uncomment it.

Is ignoring this warning if the entire line is just a comment possible?

[jdanbrown]

It would be nice if you could comment out a block of code without getting "information" warnings about reportUnnecessaryTypeIgnoreComment. Those warnings clutter up the output. But it doesn't make sense to remove from from the commented out block because you will need to add them back when you uncomment it.

Yeah, as a pyright user I strongly agree with this — when you comment out a block of code you want it to be... commented out, as if it doesn't exist. You don't want your type checker to complain that something is wrong with it.

What's the rationale for flagging # type: ignore comments as unnecessary in commented-out code? Based on the discussion above I don't understand why this is a helpful behavior, it seems to me like only a harmful behavior.