Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for pino.js logger #118

Open
vitoladev opened this issue Apr 29, 2022 · 3 comments
Open

support for pino.js logger #118

vitoladev opened this issue Apr 29, 2022 · 3 comments

Comments

@vitoladev
Copy link

It would be awesome to support pino.js Logger, it currently has 3M weekly downloads on npm, great project.

@hectorhdzg
Copy link
Member

@vitoladev we will using OpenTelemetry in Application Insights SDKs, pino is currently supported in OpenTelemetry more info here, we have a beta version of Application Insights using OpenTelemetry that you could start using along with pino instrumentation, more info about beta here

@dmunch
Copy link

dmunch commented Jun 21, 2023

@hectorhdzg I've had a look into using pino.js with the instrumentation you've linked above, and I think there's a bit of a misunderstanding of what the pino instrumentation is doing.

From reading through the source, I've understood now that the instrumentation is only adding some additional fields into the log record (trace_id, span_id, trace_flags) - however, it is not automatically sending logs created through the pino API to the diagnostic channel, like I would have hoped for.

@hectorhdzg
Copy link
Member

@dmunch yes currently only extra tracing properties are added to the logs, Logs SDK was recently added in OpenTelemetry JS, that is why auto generation of logs for this kind of libraries is still not available, this kind of functionality would be added soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants