We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently IsTrimmable is not set on a number of the Microsoft.Kiota .NET libraries as they share this incorrect condition:
IsTrimmable
<PropertyGroup Condition="'$(TargetFrameworkVersion)' == 'net5.0'"> <IsTrimmable>true</IsTrimmable> </PropertyGroup>
I would expect build errors when non-trim-safe code as added to the libraries.
The property group condition should be changed to:
<PropertyGroup Condition="'$(TargetFramework)' == 'net5.0'"> <IsTrimmable>true</IsTrimmable> </PropertyGroup>
Which causes the IsTrimmable property to be correctly set, and any expected trimming related compilation failures to occur.
I've found this issue in these projects:
The text was updated successfully, but these errors were encountered:
For additional context: while the property being used exists in some contexts it seems it wasn't the right one https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#targetframework
Additional evidence https://www.aloneguid.uk/posts/2022/08/csproj-condition-cheat-sheet/
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Current Behaviour
Currently
IsTrimmable
is not set on a number of the Microsoft.Kiota .NET libraries as they share this incorrect condition:Expected Behaviour
I would expect build errors when non-trim-safe code as added to the libraries.
Fix
The property group condition should be changed to:
Which causes the
IsTrimmable
property to be correctly set, and any expected trimming related compilation failures to occur.I've found this issue in these projects:
The text was updated successfully, but these errors were encountered: