Prevent gocrypto fallback for historical algorithms in FIPS mode #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnox
requested review from
microsoft-golang-review-bot and
a team
as code owners
Add a new boring.FIPS() API to query if the boring backend is or is not in FIPS mode. Note that currently some openssl FIPS modules return true for SupportedHash queries, for algorithms that will be blocked at runtime. Other modules choose to instead report such algorithms as not available at all, as they have become historical. Update boring backend logic for MD5, RC4, DES, 3DES to attempt to use boring backend when supported; but also when boring backend is in FIPS mode. This way FIPS module gets to decide how it is configured, and whether or not it will allow the operation. This ensures that binaries that use these algorithms, correctly fail at runtime against FIPS OpenSSL v3+ modules, like they already fail at runtime against FIPS OpenSSL 1.1.1 and earlier modules. No build/runtime behaviour changes for boringcrypto, nobackend, openssl/cng backends in non-FIPS modes.
xnox
force-pushed
the
ssl-fips-no-historical
branch
from
8155726 to
0e1c92c
Compare
aravindhkudiyarasan
approved these changes
Dec 11, 2024
|
@xnox Can we make it Ready for Review ? |
|
I needs a rebase due to other changes, and also likely a new Godebug variables, or build tags. It seems there are two desires to preserve ability to access unapproved (historical or future relative the vintage of a given fips module); or to block those. |
|
Yeah, Microsoft Go needs to be compatible. (That doesn't mean we couldn't add an "incompatible mode", but that isn't what the PR is currently, and we can't necessarily accept another mode right now because it would increase our maintenance load.) More discussion will be at #1347. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new boring.FIPS() API to query if the boring backend is or is not in FIPS mode. Add bindings for openssl and CNG, but not boringcrypto.
Note that currently some openssl FIPS modules return true for SupportedHash queries, for algorithms that will be blocked at runtime. Other modules choose to instead report such algorithms as not available at all, as they have become historical.
Update boring backend logic for MD5, RC4, DES, 3DES to attempt to use boring backend when supported; but also when boring backend is in FIPS mode. This way FIPS module gets to decide how it is configured, and whether or not it will allow the operation.
This ensures that binaries that use these algorithms, correctly fail at runtime against FIPS OpenSSL v3+ modules, like they already fail at runtime against FIPS OpenSSL 1.1.1 and earlier modules.
No build/runtime behaviour changes for boringcrypto, nobackend, openssl/cng backends in non-FIPS modes.
If this change is undesired for CNG backend, let me know, and this can be rearranged to check for the OpenSSL experiment only.
Fixes: #1347
Todo: