Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The subtitle of the dialog is 'Edit CORS Rule' instead of 'Add CORS Rule' after clicking 'Add' on the 'CORS Settings' dialog #7685

Closed
v-xianya opened this issue Jan 19, 2024 · 2 comments
Assignees
Labels
🪲 regression Issue was working in a previous version 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Milestone

Comments

@v-xianya
Copy link
Member

Storage Explorer Version: 1.33.0-dev (96)
Build Number: 20240119.2
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.2(Apple M1 Pro)
Architecture: x64/x64/x64
How Found: From running test cases
Regression From: Previous release (1.32.1)

Steps to Reproduce

  1. Expand one storage account -> Right click 'Blob Containers' node.
  2. Click 'Configure CORS Settings...' -> Click 'Add'.
  3. Observe the subtitle of the dialog.
  4. Check whether the subtitle of the dialog is 'Add CORS Rule'.

Expected Experience

The subtitle of the dialog is 'Add CORS Rule'.
image

Actual Experience

The subtitle of the dialog is 'Edit CORS Rule'.
image

@v-xianya v-xianya added 🧪 testing Found through regular testing 🪲 regression Issue was working in a previous version labels Jan 19, 2024
@craxal craxal self-assigned this Jan 19, 2024
@craxal craxal added this to the 1.33.0 milestone Jan 19, 2024
@craxal craxal added the ✅ merged A fix for this issue has been merged label Jan 19, 2024
@craxal craxal closed this as completed Jan 19, 2024
@v-xianya
Copy link
Member Author

v-xianya commented Jan 22, 2024

Hi @craxal Verified this issue on the main build 20240120.3. The current behavior as below.
The title will update to 'Edit CORS Rule' if type string to the fields on the 'Add CORS Rule' dialog. So, we are going to re-open this issue.
0122

@v-xianya v-xianya reopened this Jan 22, 2024
@MRayermannMSFT MRayermannMSFT removed the ✅ merged A fix for this issue has been merged label Jan 22, 2024
@craxal craxal closed this as completed Jan 23, 2024
@v-xianya
Copy link
Member Author

Verified this issue on the main build 20240123.7. Fixed.

@craxal craxal added the ✅ merged A fix for this issue has been merged label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 regression Issue was working in a previous version 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

3 participants