Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backcompat conflict #75

Closed
aaronpk opened this issue Dec 16, 2016 · 2 comments
Closed

Backcompat conflict #75

aaronpk opened this issue Dec 16, 2016 · 2 comments

Comments

@aaronpk
Copy link
Member

aaronpk commented Dec 16, 2016

I am not 100% sure this is a bug in the implementation or a bug in the spec, so let me know if you can tell. My new h-review posts also have backcompat hReview classes. So far, the Python parser is the only one that gets them even remotely correct. (Node parser issue, PHP parser issue)

The only thing that I didn't expect to see in the Python-parsed version was this extra h-card as a child element. It's coming from the vcard inside the h-entry, which I added there to indicate the reviewer for hReview.

Based on the mf2 wiki, I'm not totally clear whether this should be ignored or not: http://microformats.org/wiki/microformats2-parsing#note_backward_compatibility_details However, it was surprising to me that it's there, and I don't want it to show up in the mf2 parsed version.

@gRegorLove
Copy link
Member

gRegorLove commented Mar 12, 2017

An mf2 parser should ignore the reviewer vcard because it's mf1 inside an mf2 root. To make that reviewer information appear in an mf2 parser, a publisher should add p-author h-card to that same element.

This is an issue in php-mf2 as well, which I'm working on currently.

@kartikprabhu
Copy link
Member

fixed in #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants