-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nice work! #1
Comments
No problem, it is pleasure for me and occasion to learn something new 🤓 Sure I do. I will update repo soon and get rid of these "SINA"s" references. I do not know if I understand you correctly but to get rid of modifying spdlog library I needed to hardcode default progress logger to use stdout (instead of using private |
I'll have to look over the code and changes. I'm sure minor modifications to spdlog that do not impact its performance will be accepted there. |
Use std::distance to get number of terms
Thanks for starting this project! I always meant to separate the progress bar out of SINA - it was really just in there for convenience because I was lacking time.
Can you put me into the authors list here? The code is derived after all (I do recognise some of my lines). I'll toss the code out of SINA and use this instead. We can also drop the references to "SINA's progress monitor" I think.
Where there any features you dropped? IIRC I've got some code to log at larger intervals with regular lines if the sink isn't a terminal.
The text was updated successfully, but these errors were encountered: