Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice work! #1

Open
epruesse opened this issue Sep 30, 2021 · 2 comments
Open

Nice work! #1

epruesse opened this issue Sep 30, 2021 · 2 comments

Comments

@epruesse
Copy link

Thanks for starting this project! I always meant to separate the progress bar out of SINA - it was really just in there for convenience because I was lacking time.

Can you put me into the authors list here? The code is derived after all (I do recognise some of my lines). I'll toss the code out of SINA and use this instead. We can also drop the references to "SINA's progress monitor" I think.

Where there any features you dropped? IIRC I've got some code to log at larger intervals with regular lines if the sink isn't a terminal.

@michalber
Copy link
Owner

No problem, it is pleasure for me and occasion to learn something new 🤓

Sure I do. I will update repo soon and get rid of these "SINA"s" references.

I do not know if I understand you correctly but to get rid of modifying spdlog library I needed to hardcode default progress logger to use stdout (instead of using private FILE *target_file_ from spdlog sink). I was able to correctly log to both progress sink and file sink (example on the end of Readme or in src/example.cpp).

@epruesse
Copy link
Author

epruesse commented Oct 5, 2021

to get rid of modifying spdlog library I needed to hardcode default progress logger to use stdout (instead of using private FILE *target_file_ from spdlog sink)

I'll have to look over the code and changes. I'm sure minor modifications to spdlog that do not impact its performance will be accepted there.

michalber pushed a commit that referenced this issue Oct 20, 2022
Use std::distance to get number of terms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants