Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE REQUEST - Command Response Status #93

Open
glassbase opened this issue Nov 17, 2021 · 9 comments
Open

FEATURE REQUEST - Command Response Status #93

glassbase opened this issue Nov 17, 2021 · 9 comments

Comments

@glassbase
Copy link

Thanks for adding in location support.

Could we get a confirmation on the command sent to OnStar posted into MQTT somewhere.

Example: homeassistant/VIN/last_command_sent and homeassistant/VIN/last_command_status

@michaelwoods
Copy link
Owner

You're looking for a true/false status flag?

Would combining this command status with the diagnostics status break your use case? I planned to implement a general "it's broken" status when the API or car stops responding.

@BennyDaBee
Copy link
Contributor

Bump on this. Would like to see a response on Start Command Sent coming back with a true/false same with door lock/unlock

@DevDylanB
Copy link

Got everything up and running yesterday, and in my use case this is the only thing missing for my setup. I was looking in the logs and I see when the car confirms the command it says, "info: Command completed {"command":"lockDoor"}" It would be nice to have these as a value that's published with MQTT. I would like to set up push notification scripts in HomeAssistant to know when a command is sent and when it's confirmed. Still pretty new to MQTT (since yesterday), so I apologize if that's not how any of it works.

@Fumanchooo
Copy link

I'll bump this one as well. Would be nice to be notified if a command failed or the module didn't wake up to execute the command (Or if the login failed)

@BennyDaBee
Copy link
Contributor

@michaelwoods Going off of Block141s comment, would it be possible to have an MQT endpoint be published to HA with
Start Command Completed being a binary sensor that gets turned to on? This being done for each command type that gives the response. As well as if possible to have it auto reset after X time just for scripts to trigger. If not possible to reset, leave it up to us to reset them as we see fit.

@michaelwoods
Copy link
Owner

sure, however I do not have a command-capable OnStar plan at the moment so I can't really dev/test it. I'd be happy to review a PR.

@BennyDaBee
Copy link
Contributor

I am not familiar with MQTT, so if anyone is able to look at it, or I can try to help assist it would be greatly appreciated.

@BigThunderSR
Copy link
Contributor

I just updated my fork where the polling status is now published to a MQTT topic (which you specify) along with command response status where the topic is determined by the command name (README updated with schema). Please try the "latest" docker image and let me know what you think. I will publish the changes in a versioned release after I get some feedback. Thanks.

@garyd9
Copy link

garyd9 commented Dec 14, 2023

In addition, I just submitted a PR that publishes an MQTT message containing the server response for non-diagnostics/non-location commands: #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants