Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cant declare a global default hook for all containers #283

Open
dreamcat4 opened this issue Mar 26, 2016 · 2 comments
Open

cant declare a global default hook for all containers #283

dreamcat4 opened this issue Mar 26, 2016 · 2 comments
Labels

Comments

@dreamcat4
Copy link
Contributor

Hi
Doing this today:

hooks:
  default:
    pre-build: env

.. and find out its no effect, when there is no default: group been declared. But the intention should be for it to be applied for all containers.

Only tried for the pre-build: hook. But am assuming that it similarly affects all the other hook types (or maybe not?).

Anyone else noticed this before? I think it needs fixing.

@dreamcat4
Copy link
Contributor Author

Unfortunately have no idea how to fix this in the crane source code.

@michaelsauter
Copy link
Owner

Yea that looks like a bug. I would agree that it should work like you assumed it would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants