Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Datasource and DevTree code #86

Open
tristanlatr opened this issue Oct 5, 2020 · 2 comments
Open

Refactoring Datasource and DevTree code #86

tristanlatr opened this issue Oct 5, 2020 · 2 comments

Comments

@tristanlatr
Copy link
Contributor

Describe
The Datasource and DevTree codebase have to be rewritten to:

SIEM and msiempy versions:

  • msiempy: 0.3.4

Additional context
Add any other context about the problem here.

@tristanlatr
Copy link
Contributor Author

Unify the search() method across list-like objects of the library as described in the 0.3.4 release notes

In order not to change the public API of the DevTree object, the search() method could return a Datasource object if there is only one result and a list of Datasources if there are more results.

It will still be confusing because the other objects will always return a list tho...

@tristanlatr
Copy link
Contributor Author

The thing we should do here is to completely deprecate the use of DevTree object and create DataSourceManager, object with same interface BUT it should not overwrite the behaviour of the method search().
Of course the DevTree must stay around a couple of years with a deprecation notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant