Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to ESM API V2 #71

Open
tristanlatr opened this issue Sep 10, 2020 · 1 comment
Open

Transition to ESM API V2 #71

tristanlatr opened this issue Sep 10, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@tristanlatr
Copy link
Contributor

tristanlatr commented Sep 10, 2020

Describe
The whole library uses API V1 and the Private ESM API. Which is not a major issue, in any case the library will depend on private ESM methods.

Calls to ESM API should be edited inside PARAMS property ensuring the parameters stays the same (if they can)

See complete McAfee note about this: https://kc.mcafee.com/corporate/index?page=content&id=KB90289&locale=en_US

Also, not to forget, the session already handles "ESM API V1" changes across different SIEM versions with Session api_v property (can be 1 or 2) Not be confused with the ESM API v1 and v2 which are different. (It's confusing, should be changed). See #11 and #27

@tristanlatr tristanlatr added the enhancement New feature or request label Sep 10, 2020
@tristanlatr tristanlatr changed the title Use ESM API V2 by default Transition to ESM API V2 Sep 11, 2020
@tristanlatr
Copy link
Contributor Author

The diff of the v1 and v2 API docs should help: https://mfesiem.github.io/docs/esm_api/diff-v1-v2.png

tristanlatr added a commit that referenced this issue Sep 22, 2020
Transition all query related API calls to APIv2 #71

Fix the filter property setter issue #https://bugs.python.org/issue14965

Implement and test watchlist remove values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant