Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit: Keystrokes ignored when editing python_list items #2091

Open
oliver-sanders opened this issue Jul 13, 2017 · 2 comments
Open

edit: Keystrokes ignored when editing python_list items #2091

oliver-sanders opened this issue Jul 13, 2017 · 2 comments
Labels
Milestone

Comments

@oliver-sanders
Copy link
Member

Bug

Error occurs when a string outgrows its entry causing the box to expand. During this process it appears that only one keystroke may be registered.

Appears to pertain only to the python_list data type.

Occurs in normal typing, is especially evident when typing quickly and when pasting text.

Steps to reproduce:

rose-app.conf

[env]
VAR = ["some longish string", "b", "c"]

meta/rose-meta.conf

[env=VAR]
type = python_list

In rose edit, edit the first item of the list by copying the text then pasting a few times until the entry is forced to grow.

@matthewrmshin matthewrmshin added this to the soon milestone Jan 25, 2018
@matthewrmshin matthewrmshin modified the milestones: soon, next-feature Sep 19, 2019
@oliver-sanders oliver-sanders changed the title Keystrokes ignored when editing python_list items edit: Keystrokes ignored when editing python_list items Aug 9, 2021
@oliver-sanders oliver-sanders modified the milestones: 2.0.0, 2.gui Aug 9, 2021
@jfrost-mo
Copy link
Contributor

jfrost-mo commented Sep 24, 2024

(From astroDimitrios#32)

This is an issue that afflicts the rose edit 2019 as well as the rose edit python 3 version. Typing in the text box of a python list widget is really laggy, and often misses typed characters.

I suspect this is because it is reparsing the python list on every keypress, where is should really wait until the focus leaves the text box to do that, or at least have some kind of debouncing timeout. Fixing this would also help lessen the impact of #2812.

I suspect this is a Rose 2019 issue so not really one for the porting project. Should be relatively easy to jam in a debounce (something along the lines of https://stackoverflow.com/a/78227581).
- Oliver

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Sep 24, 2024

(the debounce suggestion is a good idea that might have application elsewhere too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants