Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config files are loaded from paths incosistent with debian packaging #251

Open
poobarb opened this issue Aug 16, 2018 · 4 comments
Open
Milestone

Comments

@poobarb
Copy link

poobarb commented Aug 16, 2018

The FCM documentation states that config files (such as keywords.cfg) are located from the following list of paths:

  • [$HOME/.fcm in some cases]
  • $FCM/etc/fcm/<configfile>
  • $HOME/.metomi/fcm/<configfile>

However, the Debian package for FCM (cf. here) installs the confing files to /etc/fcm (a choice which is not unreasonable), whilst it installs FCM itself to /usr/bin/. This leads to the expected config path being /usr/etc/fcm/ rather than /etc/fcm. Hence the config files are ignored.

Could FCM be modified to search the path /etc/fcm as well, leading to the following search order?

  • [$HOME/.fcm in some cases]
  • $FCM/etc/fcm/<configfile>
  • /etc/fcm/<configfile>
  • $HOME/.metomi/fcm/<configfile>
@matthewrmshin
Copy link
Member

Hi, the Debian package is not actually maintained by us. I think it is maintained by @amckinstry so you may want to check with him as well.

Otherwise, the search location is defined here:
https://github.com/metomi/fcm/blob/master/lib/FCM/Util.pm#L106
So, it should be very easy to add /etc/fcm/ to it.

Note: the $HOME/.fcm location is obsolete.

@matthewrmshin matthewrmshin added this to the soon milestone Aug 16, 2018
@amckinstry
Copy link

This change will be in Debian version fcm_2017.10.0-3, uploaded to unstable today.

@matthewrmshin
Copy link
Member

Hi @poobarb do you want us to make a change or are you happy with the solution provided by @amckinstry ?

@poobarb
Copy link
Author

poobarb commented Jan 4, 2020

Hi, sorry - just realised I never responded to this...

Thanks for changing the Debian version, that fixed the issue. However, I guess it would still be good to get this fixed upstream too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants