Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency versions are incorrect - everything is ^v2024.10.1 #345

Open
orf opened this issue Oct 24, 2024 · 5 comments
Open

Dependency versions are incorrect - everything is ^v2024.10.1 #345

orf opened this issue Oct 24, 2024 · 5 comments

Comments

@orf
Copy link

orf commented Oct 24, 2024

Hey,
The dependencies for the currently published crate are incorrect. See: https://crates.io/crates/kube-custom-resources-rs/2024.10.1/dependencies

It seems that all the dependency versions are being replaced with the crate version?

This is only present in the v2024.10.1 release: v2024.9.1 has the correct dependencies.

Screenshot 2024-10-24 at 11 28 19

@sebhoss
Copy link
Member

sebhoss commented Oct 24, 2024

yeah sorry I broke this while working on #335 - I'm going to fix this and create a new release asap.

sebhoss added a commit that referenced this issue Oct 24, 2024
related to #345

Signed-off-by: Sebastian Hoß <[email protected]>
@sebhoss
Copy link
Member

sebhoss commented Oct 24, 2024

I cannot currently publish a release because this crate is now too large for crates.io (see https://github.com/metio/kube-custom-resources-rs/actions/runs/11504507909/job/32024141108). I've contacted the crates.io team to see whether they can increase the limit for this crate.

Sorry again for the inconvenience!

@orf
Copy link
Author

orf commented Oct 24, 2024

No need to apologize - thank you for this crate!

one alternative to sidestep the size issues might be to publish each source individually as a separate crate? That would also allow releasing sub packages as they are updated/independently.

I could have a look at this if you’re interested?

@sebhoss
Copy link
Member

sebhoss commented Oct 24, 2024

Yes I'm very interested in that!

I previously reduced the release frequency because the crates team asked me to after increasing the limit of allowed features per crate which I hit last year 😅

Splitting into multiple smaller crates might be beneficial for that as well since each small crate would only declare a handful of features and thus it would be fine to release frequently changing CRDs sooner while releasing those that rarely change less frequently.

If you want to give it a shot, take a look at the code-generator folder. It contains scripts and binaries that download CRDs and move the generated code to its target destination. Currently, they all end up in that one crate, but we could split by group maybe? Or even group/version?

@orf
Copy link
Author

orf commented Oct 24, 2024

Ok! I took a look this evening. The generation scripts had some issues on my machine, so I started to add part of the functionality to the crd_fetcher_v1 file as an exercise to investigate how everything fits together.

I'll give the actual splitting into multiple crates bit a go this week, but let me know if you want me to continue with moving some of the shell script logic into crd_fetcher_v1. Absolutely no worries if not - it was just an experiment while I learn, but if you do like the idea then I can carry on in that direction.

Here's the branch so far, if you're interested. I've done up to create-mod-rs-files.sh.

main...orf:kube-custom-resources-rs:refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants