Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default config path text is confusing #29

Closed
aviramha opened this issue Jul 17, 2023 · 0 comments · Fixed by #87
Closed

Default config path text is confusing #29

aviramha opened this issue Jul 17, 2023 · 0 comments · Fixed by #87
Assignees
@meowjesty

Comments

@aviramha
Copy link
Member

When using the default .mirrord/mirrord.json file the following message shows:
image
It seems like it's default configuration, but it is actually just the default path.
@meowjesty meowjesty self-assigned this Dec 6, 2023
@meowjesty meowjesty mentioned this issue Dec 6, 2023
Merged
@meowjesty meowjesty linked a pull request Dec 6, 2023 that will close this issue
Changed warning when using .mirrord config folder to info. closes #29 #87
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 3, 2024
@meowjesty @t4lz
Changed warning when using .mirrord config folder to info. closes #29 (…
c02cae4 
…#87)

* Changed warning when using .mirrord config folder to info.

* Improve messages. // Rename confusing var. // Remove duplicated else if/else clause.

* No notification when running without config file.

* Add new prompt to disable using env var config.

* Notify we're using a default config.

* docs for no config specified

Co-authored-by: t4lz <[email protected]>

* Info only when single file.

* new specific action

* better message

Co-authored-by: t4lz <[email protected]>

* remove unused import

* changelog

---------

Co-authored-by: t4lz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meowjesty meowjesty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed warning when using .mirrord config folder to info. closes #29 meowjesty/mirrord-vscode
2 participants
@aviramha @meowjesty