Implement versioning of EIP-4824 Registration Contracts

[Rashmi-278]

As we progress, we update our smart contracts, it is a good practice to version the smart contracts and get the version information for all the registration instances. The version should be on-chain so that anyone referencing the DAO Registration Instance can be aware of the version.

After that we can get that info from The Graph API and display on our frontend

[crazyyuan]

Months ago, the EIP-4824 Registration contract had the version feature.

[Rashmi-278]

I worked on this temporary fix for Ethereum DAOs

https://daostar.org/explore

[Rashmi-278]

Months ago, the EIP-4824 Registration contract had the version feature.

Do the current contracts have this?
@crazyyuan @thelastjosh @xiaohou77
Could we create a separate Contracts Repo so that we can maintain the versioning of contracts at least on Source Code?
I realise that EIP-4824 registration contract version info might not be relevant info to store on-chain

[thelastjosh]

I'd create a contracts folder directly in the current repo, and maintain versioning of the factory registration contracts there. Looks like it exists already but it's not clear to what contracts are actually in that repo. https://github.com/metagov/daostar/tree/main/contracts The original version of the contract should be largely captured in EIP4824.

…

On Tue, Jan 23, 2024 at 2:58 PM Rashmi V Abbigeri ***@***.***> wrote: Months ago, the EIP-4824 Registration contract had the version feature. Do the current contracts have this? @crazyyuan <https://github.com/crazyyuan> @thelastjosh <https://github.com/thelastjosh> @xiaohou77 <https://github.com/xiaohou77> Could we create a separate Contracts Repo so that we can maintain the versioning of contracts at least on Source Code? I realise that EIP-4824 registration contract version info might not be relevant info to store on-chain — Reply to this email directly, view it on GitHub <#186 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACHA5PE56XUZKIE2GLVG6S3YQAI7XAVCNFSM6AAAAABATBJCCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWHAZDMMRXGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- http://www.joshuatan.com/research/

[Rashmi-278]

Josh's suggestion: https://semver.org/

[Rashmi-278]

Our Contracts have a function that returns Version of the contract, we need to index this in The Graph so that we can display the version of contract for a registration instance

function version () external pure returns(string memory){ return "1.0.0"; }

[Rashmi-278]

Pinged Kahn to help with how to query the contract to get the version

[Rashmi-278]

WIP: #207

[thelastjosh]

Hey folks, would like to get an update here! PR above is still in draft mode.

[thelastjosh]

There's already some light versioning, it would be nice to have a better plan for this but maybe that's medium priority.

[thelastjosh]

There is some light versioning.

• To wrap this issue, we need a doc explaining the versioning system somewhere, and indicating what is the difference between different versions of the contracts, where they are deployed, etc.