Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class Diagrams unnecessary wide and with white space to the left and right #1349

Closed
ismarslomic opened this issue Apr 13, 2020 · 2 comments
Closed

Class Diagrams unnecessary wide and with white space to the left and right #1349

ismarslomic opened this issue Apr 13, 2020 · 2 comments
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@ismarslomic
Copy link

Describe the bug
Class diagrams in MermaidJS v8.4.8 and 8.5.0 are unnecessary wide and leaves white space to the left and right of diagram nodes, which force user to scroll unnecessarily.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Mermaid Live Editor example
  2. Note the white space to the left and to the right of the diagram nodes

Expected behavior
Unnecessary white space to the left and right of diagram shall not be there

Desktop (please complete the following information):

  • OS: macOS Catalina
  • Browser: Firefox
  • Version: 75.0

Additional context
It seems that commit cda67f8b4454b7448ca75d62c82b2f introduced multiplying the diagram width by 1.5.
@ismarslomic ismarslomic added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Apr 13, 2020
@jgreywolf
Copy link
Contributor

Yes, This was done to correct an issue where diagrams were being cut off. I am still working on a better method for this, and hope to have something within a couple of weeks

@jgreywolf jgreywolf reopened this Apr 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2020
@github-actions github-actions bot unlocked this conversation Apr 26, 2020
@jgreywolf
Copy link
Contributor

Closing as this is being addressed via #1234

@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgreywolf @ismarslomic