Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutOfMask Sampling #26

Open
patricksnape opened this issue May 13, 2015 · 2 comments
Open

OutOfMask Sampling #26

patricksnape opened this issue May 13, 2015 · 2 comments

Comments

@patricksnape
Copy link
Contributor

When training models with MaskedImages, OutOfMaskSampleErrors may be thrown. Therefore, we should either warn about training with MaskedImage, or implicitly convert to Image using as_unmasked(copy=False).

@jabooth
Copy link
Member

jabooth commented May 13, 2015

@patricksnape I prefer the warning approach. I don't think we want users using MaskedImage instances without understanding the consequences (explicit is better than implicit)

@patricksnape
Copy link
Contributor Author

As a note about this - Menpo now throws a warning when you attempt to warp without a 1-1 correspondence between masked images. It throws an OutOfMaskSampleError which may already be solving this issue. However, perhaps we should still raise a warning when MaskedImages are passed into training?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants