non-rigid icp computing the wrong edge triangles?

[HaoyangWang]

menpo3d/menpo3d/correspond/nicp.py

Line 239 in f29324b

edge_tris = source.boundary_tri_index()

Although the edge constraint is disabled in the code, the edge triangles should be computed on the target mesh instead of the source.

[Mad-Thanos]

I guess the following line is also incorrect:

menpo3d/menpo3d/correspond/nicp.py

Line 369 in f29324b

w_i_e = np.in1d(tri_indices, edge_tris, invert=True)

the tri_indices contains triangle indices into the facet array of the target mesh, but the edge_tris is an array of boolean values. The np.in1d() does not work that way, right?

So actually at runtime, the w_i_e array is always all True.

[Mad-Thanos]

May I ask, why was the edge constraint disabled?