Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to slow or rate limit requests #99

Open
Tracked by #111 ...
klvs opened this issue May 10, 2024 · 1 comment
Open
Tracked by #111 ...

Provide option to slow or rate limit requests #99

klvs opened this issue May 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@klvs
Copy link
Contributor

klvs commented May 10, 2024

I've been testing out scrapix and first off, awesome work! With a little bit of tinkering around I got it working with meilisearch cloud FAST!

That said, it could be useful to add an option to rate limit request. I didn't see anything other than the batch_size which I believe has more to do with how frequently documents are imported into the search index.

This isn't as big an issue when it comes to indexing internal websites, but as I was testing it out on a rather large public collection of docs (reactnative.dev), it quickly stared denying my requests. Likely because scrapix was firing off LOTS of requests which might look a bit like malicious traffic.

Apache Nutch has a default rate limit of 5000ms (which in my opinion is a bit high). It could be a good idea to implement something like this for scrapix if it doesn't already exist. I could potentially implement it if you guys are welcoming PRs?

@curquiza
Copy link
Member

Hello @klvs

Thanks for the suggestion.
Pinging @meilisearch/product-team here to let them know 😇

@curquiza curquiza added the enhancement New feature or request label May 13, 2024
qdequele added a commit that referenced this issue Nov 8, 2024
This was referenced Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants