-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.8] New searchCutoffMs
index settings
#1639
Comments
TODO before closing this issue:
|
Hey @mdubus, I should have tested this PR before creating it, I didn't understand all the requirements and made a bad PR. If possible, can you revert/remove the merged PR, so that I can create a fresh PR or should I create a new PR based on Also, the |
Hey @amit-ksh 👋 No worries, your PR was great, and we're really thankful for the work you've done here! If you want to continue the work here, I suggest you create a new PR based on the As for your last question, the I hope it helps, let me know if you have any questions, and I'll do my best to help you 🌻 |
@mdubus for the answering. |
@amit-ksh your PR was definitely not bad! Thank you for opening it. And thank you for being that involved!! We just listed the missing things in the issue. It's completely ok to make part of the job and merge even if the full issue is not done 😉 |
Related to meilisearch/integration-guides#299
Explanation of the feature
Introduction of the new index setting named
searchCutoffMs
. Available via/indexes/:uid:/settings
(GET
,PATCH
,DELETE
) and/indexes/:uid:/settings/search-cutoff-ms
(GET
,PUT
,DELETE
)Default value is
null
. Expects an int as value.More info about the usage of this new feature: https://meilisearch.notion.site/Search-cutoff-usage-fb5e9a07a7624965a541d0a6f8eb37bc
TODO
searchCutoffMs
when calling the methods related to the/indexes/:uid:/settings (GET, PATCH, DELETE)
which aregetSettings()
,updateSettings()
andresetSettings
GET /indexes/:uid:/settings/search-cutoff-ms
: creategetSearchCutoffMs()
PUT /indexes/:uid:/settings/search-cutoff-ms
: createupdateSearchCutoffMs()
DELETE /indexes/:uid:/settings/search-cutoff-ms
: createresetSearchCutoffMs()
bump-meilisearch-v1.8.0
and NOTmain
. Please do 1 PR for all of these changes, and not several.The text was updated successfully, but these errors were encountered: