Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid repetition of conditions by interpolating queries #301

Open
alallema opened this issue Jul 28, 2022 · 0 comments
Open

Avoid repetition of conditions by interpolating queries #301

alallema opened this issue Jul 28, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alallema
Copy link
Contributor

Description
Following this discussion

Currently, in all the methods that allow sending a query parameter as argument like:

  • TasksQuery
  • DocumentsQuery
  • IndexesQuery
  • KeysQuery
    We check that the parameter query exists:
            if (query != null)
            {
                uri = $"{uri}?{query.ToQueryString()}";
            }

Possible solutions
It would be great to just add the query to the URI without check it.
We could use the Uri object to handle that or something like the uribuilder.

@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants